make conditions a discriminated union

Watts-Lab · Nov 1, 2024 · 6ba23d4 · 6ba23d4
1 parent 087d53c
commit 6ba23d4
Show file tree

Hide file tree

Showing 2 changed files with 408 additions and 244 deletions.
diff --git a/server/src/preFlight/validateTreatmentFile.test.js b/server/src/preFlight/validateTreatmentFile.test.js
@@ -5,7 +5,6 @@ import { expect, test } from "vitest";
 import {
   referenceSchema,
   conditionSchema,
-  introConditionSchema,
   elementsSchema,
   promptSchema,
   topSchema,
@@ -74,28 +73,28 @@ test("condition missing required value", () => {
   expect(result.success).toBe(false);
 });
 
-test("condition in intro valid", () => {
-  const condition = {
-    reference: "prompt.namedPrompt",
-    comparator: "equals",
-    value: "value",
-  };
-  const result = introConditionSchema.safeParse(condition);
-  if (!result.success) console.log(result.error.message);
-  expect(result.success).toBe(true);
-});
+// test("condition in intro valid", () => {
+//   const condition = {
+//     reference: "prompt.namedPrompt",
+//     comparator: "equals",
+//     value: "value",
+//   };
+//   const result = introConditionSchema.safeParse(condition);
+//   if (!result.success) console.log(result.error.message);
+//   expect(result.success).toBe(true);
+// });
 
-test("condition in intro errors on position", () => {
-  const condition = {
-    reference: "prompt.namedPrompt",
-    comparator: "equals",
-    value: "value",
-    position: 1,
-  };
-  const result = introConditionSchema.safeParse(condition);
-  if (!result.success) console.log(result.error.message);
-  expect(result.success).toBe(false);
-});
+// test("condition in intro errors on position", () => {
+//   const condition = {
+//     reference: "prompt.namedPrompt",
+//     comparator: "equals",
+//     value: "value",
+//     position: 1,
+//   };
+//   const result = introConditionSchema.safeParse(condition);
+//   if (!result.success) console.log(result.error.message);
+//   expect(result.success).toBe(false);
+// });
 
 // ----------- Small schemas ------------