Refactor parseYAML and validateTreatmenSchema #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shapeseas
commented
Nov 6, 2024
shapeseas
commented
- Use the data structure from safeParse in both. This is a result with success: true/false and, if true, data: [], if false, error: [].
- Now there is a consistency in return from parseYAML and validateTreatmentSchema
- Use the data structure from safeParse in both. This is a result with
success: true/false and, if true, data: [], if false, error: [].
- Now there is a consistency in return from parseYAML and
validateTreatmentSchema
- Define a language and it's associated functions (parse, validate, save, loadDefault) in languageConfig.ts, ex. yaml deals with any treatments - Makes the Code Editor more modular, as any new languages don't require edits to the CodeEditor itself - TODO: dealing with multiple files (e.g. editing a prompt in the code editor using markdown), loading to/from files (localStorage is hardcoded which won't work)
deliberation-researcher-portal
|
||||||||||||||||||||||||||||||||||
| Project |
deliberation-researcher-portal
|
| Branch Review |
eric/refactor-editor
|
| Run status |
|
| Run duration | 04m 02s |
| Commit |
|
| Committer | Eric Shapiro |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
16
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/mockPlayer.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| test spec > passes |
Test Replay
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.