Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create image masks for NF1 test data #56

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jul 23, 2024

Description

This PR adds image masks for NF1 test data using a cppipe CellProfiler file provided by @jenna-tomkinson and existing test data sampled from Plate 2. The focus here is solely on adding test data and tracking provenance through the pipefile and a Docker-based processing of the image files into masks.

References #33 (adds data needed to accomplish this work)

Thanks for any feedback you may have!

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs requested a review from jenna-tomkinson July 23, 2024 22:13
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I really like the use of Docker here! I haven't gotten to see it used practically with CellProfiler before, very neat! Great small PR!

@d33bs
Copy link
Member Author

d33bs commented Jul 23, 2024

Thanks @jenna-tomkinson ! Merging this in.

@d33bs d33bs merged commit b0957e3 into WayScience:main Jul 23, 2024
11 checks passed
@d33bs d33bs deleted the cytodataframe-image-masks branch July 23, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants