-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plate 6 samples
#55
base: main
Are you sure you want to change the base?
Update plate 6 samples
#55
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An important question! Also, what is the feature selected dataframe shape? (it would be helpful to know how many features were removed)
3.processing_features/scripts/2.pycytominer_singlecell_pipelines.py
Outdated
Show resolved
Hide resolved
@gwaybio I have updated the environments to account for the bug fix. Plate 6 single cells have now been processed correctly with the samples parameter. I did add two small changes to this PR that you can address:
NOTE: Due to trying to install the correct version of pycytominer in my main environment (held pycytominer, cytotable, and cellprofiler), it was unfortunately a mistake as the environment broke and can no longer be used (of course cause cellprofiler). I had to delete the environment and reinstall, just so CellProfiler could work. Depending on your opinion, we could reprocess all of the plates with the new environment, but that might not be necessary. |
Update Plate 6
In this PR,
samples
parameter was updated for both normalize and feature select for Plate 6 to select samples from the iNFixion cell line and WT and Null genotypes.Should we also update this for the traditional bulk method?