Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding websites #897

Merged
merged 18 commits into from
Dec 19, 2024
Merged

Adding websites #897

merged 18 commits into from
Dec 19, 2024

Conversation

3xp0rt
Copy link
Contributor

@3xp0rt 3xp0rt commented Oct 20, 2024

No description provided.

@3xp0rt
Copy link
Contributor Author

3xp0rt commented Oct 20, 2024

@WebBreacher, SimplePlanes is causing issues when parsing JSON, and it's breaking some tools. Please, review it ASAP.

@WebBreacher
Copy link
Owner

Hey @3xp0rt.

  1. Simple Planes JSON error has been fixed.
  2. I'm currently away from my workstation and cannot test/check these submissions until I return.
  3. Is there any chance you can split this massive PR into many 1-2 site smaller ones? I ask because, what I find is that a problem with 2-4 of the sites holds up a bunch of others that have no issues. Breaking this into smaller chunks allows me to merge the good ones faster.
    And thanks for the submission!

WebBreacher
WebBreacher requested changes Oct 24, 2024
View reviewed changes
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
WebBreacher
WebBreacher requested changes Dec 19, 2024
View reviewed changes
Copy link
Owner

@WebBreacher WebBreacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check these two comments and make changes.

wmn-data.json Outdated Show resolved Hide resolved
wmn-data.json Outdated Show resolved Hide resolved
@3xp0rt 3xp0rt requested a review from WebBreacher December 19, 2024 03:20
@WebBreacher WebBreacher merged commit dc40dc0 into WebBreacher:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balestek balestek balestek left review comments

@WebBreacher WebBreacher WebBreacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3xp0rt @WebBreacher @balestek