-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
big updates #907
big updates #907
Conversation
Thanks for the submission.....in the future, it'd be helpful if you did more smaller ones as I cannot approve your submissions one-by-one. I have to wait until ALL of these changes are good. In the past, I find that while 85-95% of the changes will be great, the fact that it'll take me a while to check and approve all these changes means that none of your changes happen until I'm done with everything. I DO appreciate your good work though...just saying...if you can submit more frequent and smaller PRs, that'd be faster to approve. |
I forked the repo to do some localhost tests on the updates before doing a pull request, that's why. Sorry about that. |
Would you please stop adding to this PR? You can create multiple PRs if you would like. Each time you change the PR that extends the amount of time until it can be accepted and merged. |
Oups sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed about half of the entries you submitted. Please review the changes I suggest and resubmit. I'll check what you send and then continue.
And thanks for all the work!
wmn-data.json
Outdated
"e_string" : "| Arduino Project Hub", | ||
"m_string" : "Arduino Project Hub", | ||
"m_code" : 404, | ||
"e_string" : "follow </button>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my testing, this should be follow</button>
with no space. Please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
wmn-data.json
Outdated
"m_code" : 404, | ||
"e_string" : "<meta property=\"og:title", | ||
"m_string" : ".ErrorPage-root", | ||
"m_code" : 400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm still getting a 404. Please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right
"m_string" : ">Available!</div>", | ||
"m_code" : 404, | ||
"m_string" : ">Claim Handle Now</span>", | ||
"m_code" : 200, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no issues. just adding comment to mark I've examined this change.
wmn-data.json
Outdated
"m_string" : "404 - Page not found", | ||
"m_code" : 404, | ||
"e_string" : ">Subscribe</span>", | ||
"m_string" : "404 - Page not found</h1>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing this in the page. Consider changing to <title>Bitchute</title>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"e_string" : "username", | ||
"m_string" : "response: []", | ||
"e_string" : "displayName", | ||
"m_string" : "\"response\":[]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Just adding comment to mark I've examined this change.
wmn-data.json
Outdated
@@ -1960,16 +1950,6 @@ | |||
"known" : ["RealMarjorieGreene", "LaurenBoebert"], | |||
"cat" : "political" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to insert "protection" : ["cloudflare"],
since it is behind Cloudflare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
wmn-data.json
Outdated
@@ -1760,7 +1750,7 @@ | |||
"name" : "Filmot Channel Search", | |||
"uri_check" : "https://filmot.com/channelsearch/{account}", | |||
"e_code" : 200, | |||
"e_string" : "Subscribers", | |||
"e_string" : "dth=\"Channel\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this in the response. Consider changing to Channel ID:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -1960,16 +1950,6 @@ | |||
"known" : ["RealMarjorieGreene", "LaurenBoebert"], | |||
"cat" : "political" | |||
}, | |||
{ | |||
"name" : "game_debate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Just adding comment to mark I've examined this change.
wmn-data.json
Outdated
"e_code" : 200, | ||
"e_string" : "<a ng-href=\"/u/", | ||
"m_string" : "The page you‘re trying to reach does not exist", | ||
"m_code" : 404, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got a 302 redirect which then redirected me to 404. In WMN we don't follow redirects so the response code would be 302 and the m_code
can be Redirecting to http://www.gog.com/404
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@WebBreacher I reviewed all the changes and made commit (one by one :) ) |
@@ -2434,7 +2425,7 @@ | |||
"uri_check" : "https://hiberworld.com/user/{account}", | |||
"e_code" : 200, | |||
"e_string" : "Member since ", | |||
"m_string" : "Looks like you got lost ", | |||
"m_string" : "Page Ninja'd Away!</h3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Just adding comment to mark I've examined this change.
@@ -2699,7 +2690,7 @@ | |||
"strip_bad_char" : ".", | |||
"e_code" : 200, | |||
"e_string" : "User:", | |||
"m_string" : "The requested URL /profile was not found on this server", | |||
"m_string" : "Unknown user", | |||
"m_code" : 200, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get m_code
of 404 and see that the m_string
is correct as is. I do not get the Unknown user
string. Please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a 200 and the message when testing (both with source code, curl and browser)
with this :
https://ljkhkjhkjbkhb.insanejournal.com/profile
wmn-data.json
Outdated
@@ -2765,22 +2756,11 @@ | |||
"uri_check" : "https://www.interpals.net/{account}", | |||
"e_code" : 200, | |||
"e_string" : "Looking for", | |||
"m_string" : "User not found", | |||
"m_string" : "user does not exist", | |||
"m_code" : 200, | |||
"known" : ["test"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an additional test user like alecloai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"m_code" : 404, | ||
"e_string" : "profilePictureUrl", | ||
"m_string" : "\"statusCode\":404}", | ||
"m_code" : 200, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Just adding comment to mark I've examined this change.
@@ -3507,7 +3487,7 @@ | |||
"name" : "Moto Trip", | |||
"uri_check" : "https://moto-trip.com/profil/{account}", | |||
"e_code" : 200, | |||
"e_string" : "<h1 class=\"h2\">Profil de pif</h1>", | |||
"e_string" : "<h1 class=\"h2\">Profil de", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Just adding comment to mark I've examined this change.
wmn-data.json
Outdated
@@ -3518,7 +3498,7 @@ | |||
"uri_check" : "https://www.moxfield.com/users/{account}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a uri_check
of https://api2.moxfield.com/v1/users/{account}
and then adjust the e_string
and m_string
so they work. it'll be easier. Move the current uri_check
to be uri_pretty
please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
"e_string" : "UserProfileGallery", | ||
"m_string" : "Page Not Found | VSCO</title>", | ||
"e_string" : "siteProfileImageUrl", | ||
"m_string" : "\"errorMessage\":\"site_not_found\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues. Just adding comment to mark I've examined this change.
@@ -5946,7 +5893,7 @@ | |||
"e_code" : 200, | |||
"e_string" : "on VERO™</title>", | |||
"m_string" : "The page you are looking for doesn't exist.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change m_string
to Sorry, this page is not available
@@ -6337,7 +6284,7 @@ | |||
"strip_bad_char" : ".", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the uri_check
is not great anymore since this site has archived people's blogs. Let's change it to use https://help.xanga.com/profile/{account}
for the uri_check
. Example users are brooklynheart
and eugenia
.
Please adjust other site entries to reflect the new URL responses
@@ -6437,8 +6384,8 @@ | |||
"uri_check" : "https://www.yelp.com/user_details?userid={account}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Yelp users use User IDs and not user names, please remove this site.
@@ -6537,7 +6484,7 @@ | |||
"uri_check" : "https://zmarsa.com/uzytkownik/{account}/glowna/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uri_check
redirects me to https://zmarsa.com/uzytkownik/{account}
. Can you redo the e_string
and m_string
from that page? I think the following will work:
e_string
= <title>Użytkownik
m_string
= <title>Error 404
@degun-osint This Pull Request has already been completed, merged and closed. Please create a new Pull Request for new submissions. Also, you can make changes and push them to YOUR forked version of WhatsMyName and then wait to send the Pull Request here until you have all the modifications you want. So, CHANGES -> PUSH to YOUR REPO (make more changes and push) -> PULL REQUEST HERE. This makes a single PR here. |
@degun-osint This Pull Request has already been completed, merged and closed. Please create a new Pull Request for new submissions. Also, you can make changes and push them to YOUR forked version of WhatsMyName and then wait to send the Pull Request here until you have all the modifications you want. So, CHANGES -> PUSH to YOUR REPO (make more changes and push) -> PULL REQUEST HERE. This makes a single PR here. |
Hello,
I took a few hours to update a lot of websites, deleted some which are not working anymore, and added / replaces others.