Plugin & Theme authors are now required to have 2FA enabled. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd32
commented
Oct 1, 2024
Comment on lines
-229
to
-238
| // @codeCoverageIgnoreStart | ||
| if ( ! array_key_exists( 'phpunit_version', $GLOBALS ) ) { | ||
| // 2FA is opt-in during beta testing. | ||
| // todo Remove this once we open it to all users. | ||
| if ( ! is_2fa_beta_tester( $user ) ) { | ||
| return false; | ||
| } | ||
| } | ||
| // @codeCoverageIgnoreEnd | ||
|
|
There was a problem hiding this comment.
I'm not sure why this is still in here, I think we can just remove it all?
Let's see if this breaks the unit tests on this PR..
dd32
added a commit
that referenced
this pull request
Oct 8, 2024
* Plugin & Theme authors are now required to have 2FA enabled. See https://make.wordpress.org/plugins/2024/09/04/upcoming-security-changes-for-plugin-and-theme-authors-on-wordpress-org/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://make.wordpress.org/plugins/2024/09/04/upcoming-security-changes-for-plugin-and-theme-authors-on-wordpress-org/
I'm still not 100% sure what effect this will have, as I believe they'll still have access to do many things.
Instead, we should likely focus on expanding the checks at time of action to require them to have 2FA enabled; aka WordPress/wordpress.org@0c9512e or https://meta.trac.wordpress.org/ticket/7704 (require 2FA for release confirmation)