Save power by adding delay between network requests in background. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve app initial load by delaying sticker set loading by 0.9 seconds
monich
reviewed
Jul 2, 2024
| @@ -88,7 +88,8 @@ Page { | |||
| } | |||
| Timer { | |||
| id: updateSecondaryContentTimer | |||
| interval: 600 | |||
| interval: 1500 | |||
| repeat: false | |||
There was a problem hiding this comment.
There's no need for this, repeat defaults to false
There was a problem hiding this comment.
There's no need for this,
repeatdefaults tofalse
Above this another method states "repeat: false" expicitly. I assumed that's a code style. After all it's better readable this way..
There was a problem hiding this comment.
And is this necessary at all, to increase the interval? This is a one-time action, it won't have any impact on power usage or anything like that.
There was a problem hiding this comment.
Well, yes, it's logically unrelated, I've just noticed it improves app startup performance.. Ok, I will redo the PR again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a remake of #572