Skip to content

Commit

Permalink
Document the "DefaultVote::no" policy in the code
Browse files Browse the repository at this point in the history
  • Loading branch information
wojake authored and nbougalis committed Aug 19, 2022
1 parent 6a9c270 commit cd3a6bf
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/ripple/protocol/impl/Feature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ enum class Supported : bool { no = false, yes };
// enabled using run-time conditionals based on the state of the amendment.
// There is value in retaining that conditional code for some time after
// the amendment is enabled to make it simple to replay old transactions.
// However, once an Amendment has been enabled for, say, more than two years
// However, once an amendment has been enabled for, say, more than two years
// then retaining that conditional code has less value since it is
// uncommon to replay such old transactions.
//
Expand All @@ -61,10 +61,15 @@ enum class Supported : bool { no = false, yes };
// 2018 needs to happen on an older version of the server code. There's
// a log message in Application.cpp that warns about replaying old ledgers.
//
// At some point in the future someone may wish to remove Amendment
// conditional code for Amendments that were enabled after January 2018.
// At some point in the future someone may wish to remove amendment
// conditional code for amendments that were enabled after January 2018.
// When that happens then the log message in Application.cpp should be
// updated.
//
// Generally, amendments which introduce new features should be set as
// "DefaultVote::no" whereas in rare cases, amendments that fix critical
// bugs should be set as "DefaultVote::yes", if off-chain consensus is
// reached amongst reviewers, validator operators, and other participants.

class FeatureCollections
{
Expand Down

0 comments on commit cd3a6bf

Please sign in to comment.