-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Alveo U55C cards #913
Conversation
… be used in the driver
Hi @LinusJungemann , thanks for your contribution! To setup pre-commit correctly, you can use the pre-commit configuration file that is provided in the repository. If there are issues to run pre-commit in the Docker container, a separate Python 3.10 environment can be used for that as well. |
Hi @auphelia, sorry I was not able to fix the linting until now, because of other stuff I had to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LinusJungemann .
Overall the PR looks good, there is just a small change request in the driver_base and could you please clarify how you determined the settings for the U55C platform in platforms.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LinusJungemann , looks great now!
Adds support for the Alveo U55C FPGA card to FINN.
Additionally, support to choose the FPGA device to be used for execution of the synthesized design is added to the FINN driver.