Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Alveo U55C cards #913

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

LinusJungemann
Copy link

Adds support for the Alveo U55C FPGA card to FINN.

Additionally, support to choose the FPGA device to be used for execution of the synthesized design is added to the FINN driver.

@auphelia
Copy link
Collaborator

auphelia commented Nov 7, 2023

Hi @LinusJungemann , thanks for your contribution!
Could you please make sure that the linting is successful? That will ensure that the style of your changes is in line with the rest of the repository.

To setup pre-commit correctly, you can use the pre-commit configuration file that is provided in the repository. If there are issues to run pre-commit in the Docker container, a separate Python 3.10 environment can be used for that as well.

@LinusJungemann
Copy link
Author

Hi @auphelia, sorry I was not able to fix the linting until now, because of other stuff I had to do.
It should be fixed now with the proper githook.

Copy link
Collaborator

@auphelia auphelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LinusJungemann .
Overall the PR looks good, there is just a small change request in the driver_base and could you please clarify how you determined the settings for the U55C platform in platforms.py?

src/finn/qnn-data/templates/driver/driver_base.py Outdated Show resolved Hide resolved
src/finn/util/platforms.py Show resolved Hide resolved
Copy link
Collaborator

@auphelia auphelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LinusJungemann , looks great now!

@auphelia auphelia merged commit ef9bb5f into Xilinx:dev Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants