simplified hash calculation for varchars in constant time #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple, but fast hash implementation for nullable_varchar.
Instead of iterating over all characters in O(n), it just samples the first, last and median element of the varchar in O(1), resulting in a speedup in many cases.
Result with TPC-H at scale 10 on vh001:
Old implementation:
real 64m30.605s
user 0m15.766s
sys 0m2.302s
With this PR:
real 49m39.123s
user 0m14.275s
sys 0m2.093s
The test was done with