Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: composer patches 2.0.0-beta1 #86

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

podarok
Copy link

@podarok podarok commented Jul 4, 2023

@YCloudYUSA YCloudYUSA deleted a comment from ciboxbot Jul 4, 2023
@YCloudYUSA YCloudYUSA deleted a comment from ciboxbot Jul 4, 2023
@YCloudYUSA YCloudYUSA deleted a comment from ciboxbot Jul 4, 2023
@YCloudYUSA YCloudYUSA deleted a comment from ciboxbot Jul 4, 2023
@YCloudYUSA YCloudYUSA deleted a comment from ciboxbot Jul 4, 2023
@YCloudYUSA YCloudYUSA deleted a comment from ciboxbot Jul 4, 2023
@ciboxbot
Copy link
Collaborator

ciboxbot commented Jul 4, 2023

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4267/

@podarok podarok requested a review from froboy July 4, 2023 09:17
@ciboxbot
Copy link
Collaborator

ciboxbot commented Jul 4, 2023

Open Y Complete profile installed at http://profile.openy.cibox.tools/build4268/

Copy link

@froboy froboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't totally understand the implications of removing dependency patch resolution... are there any other changes we would need to make in the rest of the decoupled modules?

Seems like we might want to hold off on merging this until any other dependencies are resolved, but if we're sure it won't break this for devs who are working off of 10.2.x then I think we're good.

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4302/

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build4302/install.php

@ciboxbot
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4302/

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4306/

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build4306/install.php

@ciboxbot
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4306/

@podarok
Copy link
Author

podarok commented Jul 25, 2023

retest this please

@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4308/

Check Open Y Installation Wizard at http://install.openy.cibox.tools/build4308/install.php

@ciboxbot
Copy link
Collaborator

Open Y Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4308/

@cweagans
Copy link

2.0.0-beta2 is now available. It includes dependency patch resolution. Thought you might like to know :)

@podarok podarok changed the base branch from 10.2.x to main February 14, 2024 08:03
@YCloudYUSA YCloudYUSA deleted a comment from ciboxbot Feb 14, 2024
@ciboxbot
Copy link
Collaborator

Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8081//job/PR_BUILDER_COMPOSER/4589/

Check YMCA Website Services Installation Wizard at http://install.openy.cibox.tools/build4589/install.php

@podarok
Copy link
Author

podarok commented Feb 14, 2024

I don't see any patches applied with beta2 version - seems like there is a breaking change in composer.json structure which breaks BC @cweagans ?

@ciboxbot
Copy link
Collaborator

YMCA Website Services Upgrade Path site check installed at http://upgrade.openy.cibox.tools/build4589/

@cweagans
Copy link

There shouldn't be :/

@podarok
Copy link
Author

podarok commented Feb 14, 2024

I see new messages like

- Syncing drupal/rat (1.0.0) into cache
patches.lock.json does not exist. Creating a new patches.lock.json.
  - Resolving patches from dependencies.
  - 

But nothing like it is now with v1 where "Applying patch log messages "

@cweagans
Copy link

Does it generate a patches.lock.json? If so, can you drop the contents here? Any other debugging information would be helpful. If you want, I'd be open to adding a test to Composer Patches directly that clones this projects, does a composer install, and verifies that the command completed successfully + maybe verify that some particular change is applied properly? (Maybe we could use a dummy patch for this that just creates an empty file or something?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants