-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abc: extract compressed Liberty files to temporary directory #4841
Draft
widlarizer
wants to merge
14
commits into
main
Choose a base branch
from
emil/gzip_abc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like ABC already has a zlib dep in tree. Might be easier to just add support for .lib.gz in ABC rather than complicating Yosys. https://github.com/berkeley-abc/abc/tree/d5e1a5d445f68bdb4895bb735b9568e5f4738c13/src/misc/zlib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will extend abc passes to use the builtin gzip capabilities of yosys to decompress
.lib.gz
files to the temporary directories used to interact withabc
. This will allow-liberty <filename>
arguments to all passes to support.lib.gz
consistently, even if it's a bit clunky and wasteful. This is sketchy, because on many systems,/tmp/
is backed bytmpfs
which is purely backed by system memory, and the point of using.lib.gz
is to handle very large Liberty files.abc
andabc9
through inheritanceThis code also adds the cleanup functionality missing from
abc_new
by holding a single per-run top-level directory which then contains the extracted Liberty files as well as the current per-module temporary directories and removing the top-level directory at the end unless-nocleanup
is set.The PR is rooted in the branch for #4834. and until that's merged and this PR is rebased. it will have a spammy diff against main