Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous world save potentially corrupting world data #5

Open
Spottedleaf opened this issue Aug 13, 2019 · 1 comment
Open

Asynchronous world save potentially corrupting world data #5

Spottedleaf opened this issue Aug 13, 2019 · 1 comment

Comments

@Spottedleaf
Copy link

https://github.com/ZombieStriker/ServerRestorer/blob/master/src/me/zombie_striker/sr/Main.java#L276

This call is made asynchronously which will call World#save() on all currently loaded worlds - if this is called asynchronously it has the potential to either crash the server or corrupt regionfile data

I see the other call to save in your code is scheduled onto the main thread - perhaps this was left as a mistake?

@Spottedleaf
Copy link
Author

I would also recommend looking disabling chunk saving when the server is making a backup - the last thing you want to backup is a mixed regionfile. See World#setAutoSave / World#isAutoSave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant