Disable auto save during server backup #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and welcome from the year 2020.
Also, can you please rebase or something to update your PR, then we can nag the author. 😝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a world is being backed up while users are exploring new terrain or the server is saving chunks/entities it can cause severe corruption in said areas (this was tested with and without disabling auto save on a local server). In many instances I loaded a backup that was saved while exploring new terrain and the console spit out tons of "chunk in wrong location" errors, with obviously corrupted chunks in the world.
Disabling auto saves during a server backup fixes this.
Apologies if I missed something, this is essentially my first week messing with Minecraft plugins in a long time.
See also: #5