Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed SFTP-Upload, added needed config entries, updated pom.xml #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

a-umar
Copy link

@a-umar a-umar commented Feb 15, 2021

Hello,
i fixed the SFTP-Upload and its now working. I also added a few config entries to be able to connect to unknown hosts and set the remote directory.
This fixes #34. fixes #25. fixes #18. fixes #16.

@Romvnly-Gaming
Copy link

merge merge

@Laukage
Copy link

Laukage commented Jul 19, 2021

Any idea why the plugin is dead and stuff like this don't get merged?

@Romvnly-Gaming
Copy link

Dunno, I moved onto DriveBackupV2.

@Laukage
Copy link

Laukage commented Jul 19, 2021

Dunno, I moved onto DriveBackupV2.

Does it have SFTP upload?

@Romvnly-Gaming
Copy link

Yep.

@Laukage
Copy link

Laukage commented Jul 20, 2021

Yep.

hmm DriveBackupV2 is pretty meh.. in terms of exemptions...

@Romvnly-Gaming
Copy link

Well, DriveBackupV2 is active and has a better code base, the configuration options were fine for me. It's much easier to PR DriveBackupV2 than it is to continue using a inactive project.

@Laukage
Copy link

Laukage commented Jul 20, 2021

Well, DriveBackupV2 is active and has a better code base, the configuration options were fine for me. It's much easier to PR DriveBackupV2 than it is to continue using a inactive project.

True, but "Active" is a big word... its not that active...

@Romvnly-Gaming
Copy link

Are any backup solutions ever that active? Also easyBackup appears to be semi active as well - might want to check that out.

@Laukage
Copy link

Laukage commented Jul 20, 2021

Are any backup solutions ever that active? Also easyBackup appears to be semi active as well - might want to check that out.

Easybackup is broken af atm.. why do you think i'm looking for alternatives xD?

@Romvnly-Gaming
Copy link

Fair enough, those are all the solutions I know. 🥲

@a-umar
Copy link
Author

a-umar commented Jul 20, 2021

I can't understand why my fix isn't merged. @ZombieStriker was active since my merge request and my server is running fine with SFTP, the latest spigot version and this fix. (over 5 month now without any problems)
@Laukage you could clone my fork and build the jar by yourself?

@Laukage
Copy link

Laukage commented Jul 20, 2021

I can't understand why my fix isn't merged. @ZombieStriker was active since my merge request and my server is running fine with SFTP, the latest spigot version and this fix. (over 5 month now without any problems)
@Laukage you could clone my fork and build the jar by yourself?
I don't know if its legally okay if i provide the .jar .....

I'm afraid i don't know how to exactly clone your fork and build it..
And theres other things i dislike in the plugin like the time interval.. i can't set a specific time sadly.. :(

@a-umar
Copy link
Author

a-umar commented Jul 20, 2021

And theres other things i dislike in the plugin like the time interval.. i can't set a specific time sadly.. :(

If you are a little bit into software development its not that hard.
I'm a little busy rightnow but i could definitly check if i could provide the jar with the fix. Adding an option for a specific time would also be possible.

@Laukage
Copy link

Laukage commented Jul 20, 2021

And theres other things i dislike in the plugin like the time interval.. i can't set a specific time sadly.. :(

If you are a little bit into software development its not that hard.
I'm a little busy rightnow but i could definitly check if i could provide the jar with the fix. Adding an option for a specific time would also be possible.

It would be awesome if you could provide the jar, just whenever u have time ^^
if you have discord, my tag is Laukage#1337

Does it work flawlessly on 1.17 and java 16?

@a-umar
Copy link
Author

a-umar commented Jul 20, 2021

And theres other things i dislike in the plugin like the time interval.. i can't set a specific time sadly.. :(

If you are a little bit into software development its not that hard.
I'm a little busy rightnow but i could definitly check if i could provide the jar with the fix. Adding an option for a specific time would also be possible.

It would be awesome if you could provide the jar, just whenever u have time ^^
if you have discord, my tag is Laukage#1337

Does it work flawlessly on 1.17 and java 16?

Yes it works fine with 1.17 and java16 :)
You could also try https://github.com/KastenKlicker/SecureServerBackup its a fork of the ServerRestorer and also provides SFTP, the owner is more active and also provides the .jar-File.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants