Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix Serialization and ABI Compatibility Update grand_product_ex… #558

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imbarty
Copy link

@imbarty imbarty commented Jan 12, 2025

I've addressed the serialization and ABI compatibility issues in the proof handling logic.
The proof is now properly serialized into bytes using serialize_uncompressed, and the sol! macro defines a struct SolProductProofAndClaims that aligns with Solidity's ABI encoding requirements.
Additionally, I added a helper function fr_to_uint256 to convert field elements to U256 and included error handling with .expect for serialization failures.

Comments have been added to clarify each step for better maintainability.

This should resolve the issues we were seeing with proof encoding and compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant