Resolve property as long as possible #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change repeats resolve property process so that
consecutive substitutions are possible. That may be
required if the property requires multiple
iterations to be resolved. For instance the
following property requires 2 iterations:
compiler.path={runtime.tools.{build.tarch}-{build.target}-elf-gcc.path}/bin
After the first iterations the form requires one
more substitution
compiler.path={runtime.tools.xtensa-esp32-elf-gcc.path}/bin
Open
|
Ran into the same issue while trying to compile a program for ESP32. This PR fixed the problem for me 👍 |
|
I support the merging of this patch as it is require to work with the ESP32 board package and Arduino and CMake. |
You'll find it merged in my fork: |
KSDaemon
added a commit
to KSDaemon/Arduino-CMake-Toolchain
that referenced
this pull request
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change repeats resolve property process so that
consecutive substitutions are possible. That may be
required if the property requires multiple
iterations to be resolved. For instance the
following property requires 2 iterations:
compiler.path={runtime.tools.{build.tarch}-{build.target}-elf-gcc.path}/bin
After the first iterations the form requires one
more substitution
compiler.path={runtime.tools.xtensa-esp32-elf-gcc.path}/bin