Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update CI workflow to be based on uv toolchain #289

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

nicholasjng
Copy link
Collaborator

This PR also does away with requirement files, and adds a lock file in their place.

The contribution guide was changed to uv-based development, currently without any instructions on how to install uv.

Left outstanding: Switch release workflow to uv (by adjusting the setup action).

This is so fast that we can even remove GitHub Actions caching.

In preparation for the switch from requirements files to a lockfile.
@nicholasjng nicholasjng self-assigned this Oct 2, 2024
@nicholasjng
Copy link
Collaborator Author

welp, pandas and sklearn were not in the docs dependencies despite the demo data science project requiring them for execution.

Since the data science notebook needs them.
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (f70e7eb) to head (9ce0c5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files           5        5           
  Lines         396      396           
  Branches       85       85           
=======================================
  Hits          368      368           
  Misses         17       17           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasjng
Copy link
Collaborator Author

15 seconds shaved off, without caching. (Not that it matters, with the way longer CodeQL and coverage jobs in the back.)

@nicholasjng nicholasjng merged commit dda9002 into main Oct 3, 2024
7 checks passed
@nicholasjng nicholasjng deleted the renew-ci branch October 3, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant