Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric): add Quadtree decomposition #77

Open
wants to merge 2 commits into
base: aim2
Choose a base branch
from

Conversation

kargaranamir
Copy link
Collaborator

@kargaranamir kargaranamir commented Jan 1, 2023

  • metric
  • support types for all variables
  • doc
  • provide tests
  • needs to check some test cases vs python2
  • add comments for functions
  • register metric in metrics.json
  • run evaluation

@kargaranamir kargaranamir requested a review from mplaine January 2, 2023 10:58
@kargaranamir
Copy link
Collaborator Author

This pull request refactors the Quadtree decomposition metric in the AIM legacy based on this paper. In all test cases, the new implementation yields the same results as the legacy implementation. I think the metric is ready to review.

  • I add another different way (it's older) of computing the Quadtree decomposition in the metric besides the legacy one. However, all the metrics are computed with the quadtree decomposition function in legacy since the paper used it as well.

    • the legacy metric used the Shanon entropy over the colored image (same as the paper). (duckduckgo example).
    • the new way I added is an old one, just using the original way of constructing quadtree based on computing std over the gray image. (most implementations on the web in different applications follow the original way, so I thought it's good to keep it). (duckduckgo example).
  • Bugs I found:

    • R_j and T_j variables are swapped in the symmetry function.
  • Issues:

    • Thresholds heavily influenced by websites as legacy code says or based on nothing!
    • Equilibrium gives high results as the legacy code says as well. see Histogram.
    • I think the symmetry results are not promising based on the histogram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant