fix: persistTheme is not memoized properly

abereghici · Dec 19, 2021 · c33d931 · c33d931
1 parent 7999103
commit c33d931
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/theme-provider.tsx b/src/theme-provider.tsx
@@ -48,6 +48,11 @@ function ThemeProvider({
   })
 
   const persistTheme = useFetcher()
+  // TODO: remove this when persistTheme is memoized properly
+  const persistThemeRef = React.useRef(persistTheme)
+  React.useEffect(() => {
+    persistThemeRef.current = persistTheme
+  }, [persistTheme])
 
   const mountRun = React.useRef(false)
 
@@ -58,7 +63,10 @@ function ThemeProvider({
     }
     if (!theme) return
 
-    persistTheme.submit({theme}, {action: themeAction, method: 'post'})
+    persistThemeRef.current.submit(
+      {theme},
+      {action: themeAction, method: 'post'},
+    )
   }, [theme])
 
   React.useEffect(() => {