-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup - type hints, remove unused imports, remove disabled auto-renewal logic, add pre-commit, etc #52
Conversation
Only set WP-CLIENT-BRAND header on shared appliances call. Bump to 0.18.8 due to that change. (hopefully) Fixes #home-assistant/core#115130 @abmantis Can I get your eyes on this when you have a moment? And if you'd prefer I do the HA fix in a PR without any cleanup I can split these, just let me know |
Confirmed on the HA issue that this change does fix the issue, so we'll definitely want this in as quickly as possible |
Thanks for this! Also, it is easier to find time during the day to review small PRs :) |
It is fine to leave the version bump out as that allows us to bundle more changes if needed, and I can do it anyway for the release |
Wanted to get things cleaned up a bit before working on the EventSocket logic, to make sure that PR didn't include extraneous stuff.
Cleanup includes:
tests/aiohttp
)Dict
/List
imports fromtyping
withdict
andlist
auth
,appliance
, andappliancesmanager
Appliance
- this one was purely for my own benefit, I wanted to get all the ones that useEventSocket
into one contiguous section__init__
methods fromWasherDryer
,Aircon
, andOven
- I can add these back if necessary, but I noticed that they weren't actually doing anything different from theAppliance
__init__
method so it seemed like they didn't need to be therejson.dumps
so it's easier to readLet me know if there are any concerns with these changes or if there are formatting conventions that this project uses that I may have missed.
Note: I didn't bump the version since there are no actual functionality changes and figured we wouldn't both bumping until there were new features/changes.