Consul beer fridges integration #63
Conversation
There was a problem hiding this comment.
Thanks for the contribution! Left a couple of suggestions.
It seems that the options are not beer specific and could work with any smart fridge and not only for bear fridges.
Should we rename things to refrigerator instead of beer_fridge? It seems that refrigerator is the term used by whirlpool anyway
Also, can you please add tests for the new appliance? Thanks
|
Thanks for your review, I updated the PR, let me know if you have any other concern about this implementation. |
Co-authored-by: Abílio Costa <[email protected]>
…leandrocaldas/whirlpool-sixth-sense into consul_beer_fridges_integration
Co-authored-by: Abílio Costa <[email protected]>
|
Thanks a lot! |
|
Very nice, now could you include this integration in HA? Any question let me know and I can test it during development. |
|
Hey @leandrocaldas . I can't promise, but I'll add it to my TODO list. |
hi @abmantis I inserted a new integration equipemt smartbeer, it uses a US whirlpool api, it is a Brazilian brand called consul, it is a fridge dedicated to beer, and there are some functionality, I tryed following the current structure but if has some thing to fix let me know. Now I should develop the Home assistant side, but I never delevoled some thing to HA.