Move event socket to Appliances Manager #72
Conversation
This was a merge of @NodeJSmith's move_event_socket_to_app_manager branch.
|
Glad to see my branch had some merit! Never got around to finishing that up. Let me know if you have any questions on my changes or if you like another set of eyes (or hands) for any changes. I might try to spend a bit more time contributing if the code base is getting cleaned up |
I'm glad you did it. I was going through the open issues and found your link there so it saved me a fair amount of work. |
|
Sorry...work got in the way. Where do we stand on these PRs? Was there something else that I was supposed to be changing? |
There are a few comments that are still not addressed |
|
Oh, geez. I missed a lot of them. Will work on them tonight. |
whirlpool/types.py
Outdated
|
|
||
|
|
||
| @dataclass | ||
| class ApplianceData: |
There was a problem hiding this comment.
| class ApplianceData: | |
| class ApplianceInfo: |
since we already call appliance data to the actual data (temperature, mode, etc), lets name this Info to reduce ambiguity.
|
|
||
| self._session: aiohttp.ClientSession = session | ||
|
|
||
| def register_attr_callback(self, update_callback: Callable): |
There was a problem hiding this comment.
Not sure what you mean for me to do here. Just let me know and I'll get 'er done.
| "Cache-Control": "no-cache", | ||
| } | ||
|
|
||
| def _set_attribute(self, attribute, value, timestamp): |
whirlpool/oven.py
Outdated
| @@ -170,32 +168,29 @@ def get_state(self): | |||
| return None | |||
|
|
|||
| async def set_timer(self, timer_time: int, operation=KitchenTimerOperations.Start): | |||
| await self._appliance.send_attributes( | |||
| await self.send_attributes( | |||
whirlpool/appliance.py
Outdated
| def _update_appliance_attributes(self, attrs: dict[str, str], timestamp: str): | ||
| for attr, val in attrs.items(): | ||
| if self.has_attribute(attr): | ||
| self._set_attribute(attr, str(val), timestamp) |
There was a problem hiding this comment.
| self._set_attribute(attr, str(val), timestamp) | |
| self._set_attribute(attr, val, timestamp) |
There was a problem hiding this comment.
I "think" these are "reversals" of earlier review points???
I really thought I'd addressed them all! I have no idea why I'm not seeing everything! I realized that HA will not be adequate (yet) for my purposes, so I had to revert to writing an Alexa skill to interface directly to the dryer. Nearly done with that, so I'll address the above issues shortly...probably in a couple of days. |
Maybe you missed the button to expand? You wouldn't be the first eheh.
Oh. Why not connect HA to Alexa? |
Yepper, did that. But, it felt a little clunky and since Alexa doesn't support the same entity types that HA does, I'd need to fiddle around with "forcing" this integration. So, I figured a skill built for purpose would be best, at least until I can get my hands on a decent voice assistant for HA. I'm not opposed to building one myself, but there's a couple of decent sounding ones coming out and I'd rather have someone else build it for me. :-) |
This was a merge of @NodeJSmith's move_event_socket_to_app_manager branch.
First step of merging my changes.