-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add jsdoc types #79
base: master
Are you sure you want to change the base?
Conversation
This is a nice set of changes. Are the What does this need to be out of draft? |
Yeah,TS is still doing all the work - it's just pulling types from the comments, instead. I put it up as a draft because I wasn't sure if I should leave it as is (i.e. leave the errors and skip type checking during CI) or wait until I make the refractors necessary to eliminate the errors. |
No idea what I was thinking using "style" for one commit but "chore" for the rest 😅 |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 97.57% 97.50% -0.08%
==========================================
Files 31 31
Lines 1280 1281 +1
==========================================
Hits 1249 1249
- Misses 31 32 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
My thinking is the best strategy would be to merge in small changes that are solid improvements - under that strategy, I think working type checking enabled in CI is a stronger change (even if only for a few files). What do you think? |
Here is the current progress on my light-weight refactor with JSDoc types, as mentioned in #29