[feature] signal on a semaphore when the proxy-server is initialized #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. The pull request looks good. However, before I merge it: have you had any feedback from Galois regarding GaloisInc/http-server/#9 ? Also, for stack, please, consider testing against the latest LTS-4.0. I don't expect any problems as I've recently built the current tip of master on it, but would be good to know anyway. |
|
I don't recommend merging ahead of Galois because that will break There's been no response from Galois on the PR, which is now 1 month old. I've built against lts-4.0 and tested. 👍 |
|
Yeah, that was my thought as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is blocked by GaloisInc/http-server#9
If one wants to run the proxy within a larger program in its own thread, it is advantageous to know when the proxy has finished initializing.
proxyMaintoproxyMain_and changed it to accept an additionalMVar ()argument. It signals (non blocking) on that semaphore just before waiting on the socket for connections (pending [feature] signal on a semaphore when the server is initialized GaloisInc/http-server#9).proxyMainwhich does exactly what the old one did, but usesproxyMain_.stack.yamlfile for users of stack and included its work dir to the.gitignorefile.Changes to the API dictate a minor-version bump (adding a new function).