OcBootManagementLib: Add missing explicit initialisation of mImageLoa…

…derCaps in OcImageLoaderLoad (#496) Fix mentioned in changelog incorporates this and the previous commit
acidanthera · Oct 30, 2023 · 7f08cc7 · 7f08cc7
1 parent c6060b2
commit 7f08cc7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -4,6 +4,7 @@ OpenCore Changelog
 - Updated builtin firmware versions for SMBIOS and the rest
 - Fixed hang while generating boot entries on some systems
 - Added `efidebug.tool` support for 32-bit on 32-bit using GDB or LLDB
+- Fixed potential incorrect values in kernel image capabilities calculation
 
 #### v0.9.5
 - Fixed GUID formatting for legacy NVRAM saving

diff --git a/Library/OcBootManagementLib/ImageLoader.c b/Library/OcBootManagementLib/ImageLoader.c
@@ -270,6 +270,17 @@ OcImageLoaderLoad (
   OC_LOADED_IMAGE_PROTOCOL         *OcLoadedImage;
   EFI_LOADED_IMAGE_PROTOCOL        *LoadedImage;
 
+  //
+  // For OcImageLoaderLoad always assume target default.
+  //
+ #ifdef MDE_CPU_IA32
+  mImageLoaderCaps = OC_KERN_CAPABILITY_K32_U32 | OC_KERN_CAPABILITY_K32_U64;
+ #else
+  mImageLoaderCaps = OC_KERN_CAPABILITY_K64_U64;
+ #endif
+
+  mImageLoaderCapsHandle = NULL;
+
   ASSERT (SourceBuffer != NULL);
 
   //
@@ -411,6 +422,8 @@ OcImageLoaderLoad (
     return Status;
   }
 
+  mImageLoaderCapsHandle = *ImageHandle;
+
   DEBUG ((DEBUG_VERBOSE, "OCB: Loaded image at %p\n", *ImageHandle));
 
   return EFI_SUCCESS;