Fix wrong definition for AMD_CPU_EXT_FAMILY_1AH #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vit9696
reviewed
Oct 12, 2024
| @@ -258,7 +258,7 @@ typedef enum { | |||
| #define AMD_CPU_EXT_FAMILY_16H 0x7 | |||
| #define AMD_CPU_EXT_FAMILY_17H 0x8 | |||
| #define AMD_CPU_EXT_FAMILY_19H 0xA | |||
| #define AMD_CPU_EXT_FAMILY_1AH 0x1A | |||
| #define AMD_CPU_EXT_FAMILY_1AH 0x0B | |||
There was a problem hiding this comment.
Please change to 0xB. How should the changelog be updated?
There was a problem hiding this comment.
Changed. As for changelog maybe,
Adjusted AMD Family 1Ah CPU support to use 0xB for AMD_CPU_EXT_FAMILY_1AH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined the CPU family wrong. This fixes it.