Remove Gunicorn #79
Open
Remove Gunicorn #79
+128
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-musing-moose
requested review from
zahraaalizadeh,
heykarimoff and
jadedarko
jadedarko
reviewed
Jan 15, 2025
template/pyproject.toml
Outdated
| @@ -16,8 +16,8 @@ psycopg = "^3.1.12" | |||
| python = "^3.12" | |||
| uvicorn = "^0.24.0" | |||
There was a problem hiding this comment.
issue If we're relying on this being > 0.30.0, we should update it here
There was a problem hiding this comment.
🤦🏼 - Thanks, that was a silly omission. I'm going to bump to the latest revision.
jadedarko
reviewed
Jan 15, 2025
| UVICORN_WORKERS="${UVICORN_WORKERS:-4}" | ||
|
|
||
| serve () { | ||
| exec uvicorn \ |
There was a problem hiding this comment.
question the gunicorn config was in a config file, should this stay inline or be in a separate config file?
There was a problem hiding this comment.
As far as I can tell, uvicorn does not support passing config as a file. Which is why I opted to switch back to inline config like this.
jadedarko
requested changes
Jan 15, 2025
Uvicorn now has process management, so we can use that directly and remove the need for Gunicorn. I also took the opportunity to update the default logging so it pretty closely matches the default logging format used by uvicorn. This prevents the jarring changed when the Django logging is configured.
a-musing-moose
force-pushed
the
70/unicorn-only
branch
from
7c97eef to
eb0e760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uvicorn now has process management, so we can use that directly and remove the need for Gunicorn.
I also took the opportunity to update the default logging so it pretty closely matches the default logging format used by uvicorn. This prevents the jarring changed when the Django logging is configured.
resolves #70