-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gunicorn #79
Open
a-musing-moose
wants to merge
1
commit into
main
Choose a base branch
from
70/unicorn-only
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove Gunicorn #79
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# 0002 Remove Gunicorn as a Process Manager | ||
|
||
- Date: 2025-01-015 | ||
- Author(s): [Jonathan Moss][jmoss] | ||
- Status: `Active` | ||
|
||
## Decision | ||
|
||
[Uvicorn][uvicorn] now has built in support for process management, so we no longer need | ||
[Gunicorn][gunicorn] as well. | ||
|
||
## Context | ||
|
||
An ASGI runtime is needed to support asyncio operations in Django. We currently use | ||
Uvicorn for this. Previously Uvicorn ran as a single process and it was recommended that | ||
Gunicorn was used as a process manager, configured to use Uvicorn purely for the | ||
workers. This is no longer the case, as of release [0.30.0][release] Uvicorn now has | ||
built in process management support. | ||
|
||
## Implications | ||
|
||
This removes one of the moving part of our stack, reducing the over all number of | ||
packages we need to understand and keep up to date. | ||
|
||
Whilst some benchmarking has been performed - it is not exhaustive. The general results | ||
however show a comparable level of throughput to what we had with the previous gunicorn | ||
setup. | ||
|
||
<!-- Links --> | ||
[jmoss]: mailto:[email protected] | ||
[uvicorn]: https://www.uvicorn.org/ | ||
[gunicorn]: https://gunicorn.org/ | ||
[release]: https://www.uvicorn.org/release-notes/#0300-2024-05-28 | ||
|
||
<!-- Abbreviations --> | ||
*[ASGI]: Asynchronous Server Gateway Interface |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question the gunicorn config was in a config file, should this stay inline or be in a separate config file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, uvicorn does not support passing config as a file. Which is why I opted to switch back to inline config like this.