Performance - Inefficient caching on related skus. (#65)

modules/sku/src/AcmSkuLinkedSku.php

@@ -83,60 +83,34 @@ public function __construct(APIWrapper $api_wrapper, CacheBackendInterface $cach
    *   All linked skus of given type.
    */
   public function getLinkedskus(SKU $sku, $type = LINKED_SKU_TYPE_ALL) {
-    $linked_skus = [];
-
-    // Cache key is like - 'acm_sku:linked_skus:123'.
-    $cache_key = 'acm_sku:linked_skus:' . $sku->id();
-
+    // Cache key is like - 'acm_sku:linked_skus:123:LINKED_SKU_TYPE_ALL'.
+    $cache_key = 'acm_sku:linked_skus:' . $sku->id() . ':' . $type;
     // Get cached data.
     $cache = $this->cache->get($cache_key);
-
     // If already cached.
     if ($cache) {
-      // If only for specific type like cross_sell/upsell/related.
-      if (isset($cache->data[$type])) {
-        return $cache->data[$type];
-      }
-      elseif ($type == LINKED_SKU_TYPE_ALL && isset($cache->data[LINKED_SKU_TYPE_RELATED]) && isset($cache->data[LINKED_SKU_TYPE_CROSSSELL]) && isset($cache->data[LINKED_SKU_TYPE_UPSELL])) {
-        // Returning everything in case of 'all' and all keys set.
-        return $cache->data;
-      }
+      return $cache->data;
     }
-
+    $data = [];
     try {
       // Get linked skus and set the cache.
       $linked_skus = $this->apiWrapper->getLinkedskus($sku->getSku(), $type);
-
-      // If cache is set already and we just fetching info of perticular type,
-      // just updating the existing cache.
-      if ($type != LINKED_SKU_TYPE_ALL && $cache) {
-        $cache->data[$type] = $linked_skus[$type];
-        $linked_skus = $cache->data;
-      }
-      elseif ($type != LINKED_SKU_TYPE_ALL && !$cache) {
-        $linked_skus = [$type => $linked_skus[$type]];
-      }
-
+      $data = $type != LINKED_SKU_TYPE_ALL ? $linked_skus[$type] : $linked_skus;
       // Set the cache.
       if ($cache_lifetime = $this->configFactory->get('acm_sku.settings')->get('linked_skus_cache_max_lifetime')) {
         $cache_lifetime += \Drupal::time()->getRequestTime();
-        $this->cache->set($cache_key, $linked_skus, $cache_lifetime, ['acm_sku:' . $sku->id()]);
+        $this->cache->set($cache_key, $data, $cache_lifetime, ['acm_sku:' . $sku->id()]);
       }
-
-      // Return the data.
-      return $type != LINKED_SKU_TYPE_ALL ? $linked_skus[$type] : $linked_skus;
     }
     catch (\Exception $e) {
       // If something bad happens, log the error.
       $this->loggerFactory->get('acm_sku')->emergency('Unable to get the @linked_sku_type linked skus for @sku : @message', [
         '@linked_sku_type' => $type,
         '@sku' => $sku->getSku(),
         '@message' => $e->getMessage(),
-      ]
-      );
+      ]);
     }
-
-    return $linked_skus;
+    return $data;
   }
 
 }