- fix linter

- add security CI action

.github/workflows/lint.yml

@@ -0,0 +1,32 @@
+name: Lint
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+permissions:
+  contents: read
+jobs:
+  lint:
+    strategy:
+      matrix:
+        go: [ '1.20' ]
+      fail-fast: true
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v3
+
+      - name: Setup Go ${{ matrix.go }}
+        uses: actions/setup-go@v4
+        with:
+          go-version: ${{ matrix.go }}
+          cache: false
+
+      - name: Run GolangCI-Lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: v1.56.1
+          args: --timeout=5m

.github/workflows/sec.yml

@@ -0,0 +1,32 @@
+name: Security Scan
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+permissions:
+  contents: read
+  id-token: write
+  issues: write
+  pull-requests: write
+
+jobs:
+  TruffleHog:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Secret Scanning
+        uses: trufflesecurity/trufflehog@main
+        with:
+          extra_args: --only-verified

.github/workflows/ci.yml → .github/workflows/test.yml

@@ -1,4 +1,4 @@
-name: Go CI
+name: Test
 
 on:
   push:
@@ -8,25 +8,39 @@ on:
     branches:
       - master
 
+permissions:
+  contents: read
+
 jobs:
   test_and_lint:
     name: Test, Lint, and Coverage
-    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        go: [ '1.20' ]
+        os: [ ubuntu-latest, macos-latest, windows-latest ]
+      fail-fast: true
+    runs-on: ${{ matrix.os }}
 
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
 
-      - name: Set up Go
+      - name: Setup Go ${{ matrix.go }}
         uses: actions/setup-go@v4
         with:
-          go-version: 1.20
+          go-version: ${{ matrix.go }}
+          cache: false
 
       - name: Install dependencies
         run: go mod download
 
       - name: Run tests with coverage
-        run: go test ./... -v -coverprofile=coverage.out
+        run: go test -race -cover -coverprofile="coverage.out" -covermode=atomic -v ./...
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3
+        with:
+          files: ./coverage.out
 
       - name: Calculate coverage
         run: go tool cover -func=coverage.out | grep total | awk '{print substr($3, 1, length($3)-1)}'
@@ -41,9 +55,3 @@ jobs:
           else
             echo "Code coverage ($COVERAGE%) meets the threshold of 75%."
           fi
-
-      - name: Install GolangCI-Lint
-        run: go install github.com/golangci/golangci-lint/cmd/[email protected]
-
-      - name: Run GolangCI-Lint
-        run: golangci-lint run

httpclient/example_rate_limiting_round_tripper_test.go

@@ -52,7 +52,7 @@ func ExampleNewRateLimitingRoundTripper() {
 		prev = now
 	}
 	delta := time.Since(start) - time.Second*2
-	if delta > time.Millisecond*10 {
+	if delta > time.Millisecond*20 {
 		fmt.Println("Total time is much greater than 2s")
 	} else {
 		fmt.Println("Total time is about 2s")

httpserver/config.go

@@ -28,7 +28,7 @@ const (
 	cfgKeyServerLogRequestStart         = "server.log.requestStart"
 	cfgKeyServerLogRequestHeaders       = "server.log.requestHeaders"
 	cfgKeyServerLogExcludedEndpoints    = "server.log.excludedEndpoints"
-	cfgKeyServerLogSecretQueryParams    = "server.log.secretQueryParams" //nolint:gosec
+	cfgKeyServerLogSecretQueryParams    = "server.log.secretQueryParams" // nolint:gosec // false positive
 	cfgKeyServerLogAddRequestInfo       = "server.log.addRequestInfo"
 	cfgKeyServerLogSlowRequestThreshold = "server.log.slowRequestThreshold"
 )

httpserver/health_check_test.go

@@ -177,7 +177,7 @@ func TestHealthCheckHandlerContext_ServeHTTP(t *testing.T) {
 		timeout := 1 * time.Millisecond
 
 		h := NewHealthCheckHandlerContext(func(ctx context.Context) (HealthCheckResult, error) {
-			time.Sleep(timeout + 1*time.Millisecond)
+			time.Sleep(timeout + 5*time.Millisecond)
 			return HealthCheckResult{}, ctx.Err()
 		})
 		resp := httptest.NewRecorder()

httpserver/middleware/rate_limit_test.go

@@ -11,6 +11,7 @@ import (
 	"math"
 	"net/http"
 	"net/http/httptest"
+	"runtime"
 	"strconv"
 	"sync"
 	"testing"
@@ -191,6 +192,10 @@ func TestRateLimitHandler_ServeHTTP(t *testing.T) {
 	})
 
 	t.Run("leaky bucket, maxRate=10r/s, maxBurst=10, by key", func(t *testing.T) {
+		if runtime.GOOS == "windows" {
+			t.Skip("Skip on Windows as unstable")
+		}
+
 		const headerClientID = "X-Client-ID"
 		rate := Rate{10, time.Second}
 		const (