Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat-NG reply messages preview #2430

Merged
merged 11 commits into from
Dec 20, 2024
Merged

Conversation

gtalha07
Copy link
Contributor

@gtalha07 gtalha07 commented Dec 12, 2024

build on top of #2426 as it brings core structural improvements to messages UI, this includes reply messages preview along with proper automatic provider updates on repliedTo message ids whenever valid reference gets available. Also supports nice error UI handling.

Preview:

showcases the replied to content UI and notice how the original event gets available on server fetch when paginating:

Screen.Recording.2024-12-17.at.16.18.03.mov

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.72%. Comparing base (0ae3b8a) to head (eade8ff).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2430      +/-   ##
==========================================
+ Coverage   27.60%   27.72%   +0.12%     
==========================================
  Files         651      657       +6     
  Lines       43921    44743     +822     
==========================================
+ Hits        12125    12407     +282     
- Misses      31796    32336     +540     
Flag Coverage Δ
integration-test 37.95% <ø> (+0.07%) ⬆️
unittest 19.08% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gtalha07 gtalha07 marked this pull request as ready for review December 17, 2024 11:19
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI/UX wise looks good but I think we can do better code wise. In particular around two aspects of the way this is being implemented: a) better separation of concerns - it's not metadata if it is purely about the way the same object is rendered differently depending on context (I marked that situation)
b) I think the bubble should not become too intelligent, but be a dump widget that other higher level objects use to render their widgets (or not). For reusability we can have common code (e.g. a Reply-To-Widget-Builder) in a (abstract) widget that others mix in or can inherit from. I think that is better, cleaner separation and leads to bigger reusability than tweaking a "metadata" object you pass around to maybe show a bubble or not...

@gtalha07 gtalha07 requested a review from gnunicorn December 19, 2024 15:07
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@gtalha07 gtalha07 merged commit 8339943 into acterglobal:main Dec 20, 2024
22 of 23 checks passed
@gtalha07 gtalha07 deleted the ng_reply-builder branch December 20, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants