Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefDetail enhancement on Space Objects #2440

Merged
merged 12 commits into from
Dec 26, 2024

Conversation

kumarpalsinh25
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 commented Dec 17, 2024

THIS PR GETS BIT LARGER THEN EXPECTED BUT I WILL TRY TO EXPLAIN ALL THE DETAIL IN PR DESCRIPTION AND COMMENTS TO MAKE IT EASIER FOR REVIEWERS. ENTIRE PR WORK IS WELL SEPARATED BY COMMITS BUT IT REQUIRES BIT OF IN-DEPTH DETAIL WHICH I TRIED TO COVER AS MUCH AS POSSIBLE IN PR DESCRIPTION.


Boost Actions Enhancement: Make it beyond selected space boundry.

  • Currently boost actions are only belongs to selected space in which we are going to post Boost but it is now enhanced and user can post any space action items to space boost.

1) Changes related to Add Boost:

  • First I have removed space selection restriction while adding actions on the boost by below commit.
    86ccfd8
  • Then I have removed custom NewsReferencesModel class and use default RefDetails class in relevant code of Boosts by below commit.
    e9cc2a0
  • Reference Video :
Add.Boost.Actions.-.Beyond.Space.Boundry.mov

2) Changes related to View Boost:

  • Now on view part, Boost Actions (Space Objects) on which we have access (Space we already joined) are visible as expected.
  • But Boost Actions (Space Objects), on which we do not have any access (Space we haven't joined) are not visible directly so for that I created common ReferenceDetailsItem class which shows static data based on the refDetails.
  • To handle it in more better way, I have used ReferenceDetailsItem in PinListItemWidget, EventItem and in TaskListItemCard based on the required conditions.
  • NewsSlideActions for boost post is now becomes more clear and can directly used PinListItemWidget, EventItem and in TaskListItemCard classes without working about anything else.
  • All the work is implemented in below commit.
    92c37c1
  • Reference Video:
Boost.View.mov

Attachment List Improvements:

  • ReferenceAttachmentItem class got bit messy on my earlier PR - Space Object internal Sharing due to couple of refObjectType conditions.
  • Now it got much cleaner by directly using PinListItemWidget, EventItem and in TaskListItemCard classes. You will find this changes in below commit.
    8d95353
  • Now last thing left in Attachment list is to separate References List and General Attachment List in UI which is managed by below commit.
    9511599
  • Reference Image:

Frame 15


KNOWN THINGS:

  • Still after this much work, Add Ref directly from Space Object Screen and Remove Ref Attachment work gets pending with I would like to do in Follow-up PR as this PR already gets enough work to cover.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.81%. Comparing base (025dd7b) to head (74a559d).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
+ Coverage   27.60%   27.81%   +0.20%     
==========================================
  Files         651      657       +6     
  Lines       43921    44618     +697     
==========================================
+ Hits        12125    12410     +285     
- Misses      31796    32208     +412     
Flag Coverage Δ
integration-test 37.97% <ø> (+0.09%) ⬆️
unittest 19.16% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kumarpalsinh25 kumarpalsinh25 changed the title Boost : Add actions enhancement RefDetail enhancement on Space Objects Dec 20, 2024
@kumarpalsinh25 kumarpalsinh25 marked this pull request as ready for review December 20, 2024 07:31
Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few inner code style things, but leave it to you to do this now or later.

@kumarpalsinh25 kumarpalsinh25 merged commit 39dd072 into main Dec 26, 2024
23 checks passed
@kumarpalsinh25 kumarpalsinh25 deleted the kumar/boost-share-improvements branch December 26, 2024 12:48
@kumarpalsinh25 kumarpalsinh25 mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants