-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RefDetail enhancement on Space Objects #2440
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
==========================================
+ Coverage 27.60% 27.81% +0.20%
==========================================
Files 651 657 +6
Lines 43921 44618 +697
==========================================
+ Hits 12125 12410 +285
- Misses 31796 32208 +412
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few inner code style things, but leave it to you to do this now or later.
THIS PR GETS BIT LARGER THEN EXPECTED BUT I WILL TRY TO EXPLAIN ALL THE DETAIL IN PR DESCRIPTION AND COMMENTS TO MAKE IT EASIER FOR REVIEWERS. ENTIRE PR WORK IS WELL SEPARATED BY COMMITS BUT IT REQUIRES BIT OF IN-DEPTH DETAIL WHICH I TRIED TO COVER AS MUCH AS POSSIBLE IN PR DESCRIPTION.
Boost Actions Enhancement: Make it beyond selected space boundry.
1) Changes related to Add Boost:
86ccfd8
NewsReferencesModel
class and use defaultRefDetails
class in relevant code of Boosts by below commit.e9cc2a0
Add.Boost.Actions.-.Beyond.Space.Boundry.mov
2) Changes related to View Boost:
ReferenceDetailsItem
class which shows static data based on therefDetails
.ReferenceDetailsItem
inPinListItemWidget
,EventItem
and inTaskListItemCard
based on the required conditions.NewsSlideActions
for boost post is now becomes more clear and can directly usedPinListItemWidget
,EventItem
and inTaskListItemCard
classes without working about anything else.92c37c1
Boost.View.mov
Attachment List Improvements:
ReferenceAttachmentItem
class got bit messy on my earlier PR - Space Object internal Sharing due to couple ofrefObjectType
conditions.PinListItemWidget
,EventItem
and inTaskListItemCard
classes. You will find this changes in below commit.8d95353
9511599
KNOWN THINGS: