Improvement in refDetail and Space Object sharing enhancements #2472

kumarpalsinh25 · 2024-12-31T10:58:53Z

This PR contains general code improve in Space Object Sharing code and enhancement of sharing options by enabling External Sharing Options.

Screen.Recording.2025-01-03.at.10.36.06.AM.mov

Also, User invite share screen now used common sharing UI-UX.

Screen.Recording.2025-01-03.at.10.37.43.AM.mov

codecov · 2024-12-31T11:00:33Z

Codecov Report

Attention: Patch coverage is 57.89474% with 96 lines in your changes missing coverage. Please review.

Project coverage is 27.91%. Comparing base (de5bf23) to head (fc355da).
Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
native/acter/src/api/deep_linking.rs	59.15%	58 Missing ⚠️
native/acter/src/api/stories.rs	0.00%	18 Missing ⚠️
native/acter/src/api/news.rs	11.11%	16 Missing ⚠️
native/acter/src/testing.rs	75.00%	2 Missing ⚠️
native/acter/src/api/attachments.rs	50.00%	1 Missing ⚠️
native/acter/src/api/common.rs	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
+ Coverage   27.76%   27.91%   +0.15%     
==========================================
  Files         660      660              
  Lines       44697    44775      +78     
==========================================
+ Hits        12410    12499      +89     
+ Misses      32287    32276      -11

Flag	Coverage Δ
integration-test	`38.33% <57.89%> (+0.35%)`	⬆️
unittest	`19.10% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…into kumar/ref-details-improvements

kumarpalsinh25

Added few comment for code explanation.

kumarpalsinh25 · 2025-01-03T04:45:40Z

app/lib/common/providers/app_install_check_provider.dart

@@ -3,7 +3,7 @@ import 'dart:io';
 import 'package:appcheck/appcheck.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';

-enum ExternalApps { whatsApp, telegram, signal }
+enum ExternalApps { whatsApp, whatsBusiness, telegram, signal }


Added WhatsBusiness app direct share option.

kumarpalsinh25 · 2025-01-03T04:46:26Z

app/lib/common/widgets/share/action/mail_to.dart

Just moved file to different folder.

kumarpalsinh25 · 2025-01-03T04:48:15Z

app/lib/common/widgets/share/action/shareTo.dart

+  required BuildContext context,
+  required String text,
+}) async {
+  if (Platform.isAndroid) {


Direct share to Signal App only available for android platform with Explicit Intent.

For iOS users, given better guide about sharing to Signal.

We usually do the path of only showing features if they are available - if this isn't possible on iOS rather than showing some error messages, the button should not show up.

kumarpalsinh25 · 2025-01-03T04:49:29Z

app/lib/common/widgets/share/action/share_space_object_action.dart

-typedef SpaceObjectDetails = ({
-  String spaceId,
-  ObjectType objectType,
-  String objectId,
-});
-


Get rid of SpaceObjectDetails and use RefDetails param directly to sharing options.

kumarpalsinh25 · 2025-01-03T04:50:46Z

app/lib/common/widgets/share/action/share_space_object_action.dart

+  Future<String> Function()? shareContentBuilder,
+  Future<FileDetails> Function()? fileDetailContentBuilder,


ExternalLink and FileSharing will be based on the callback function which make data accessing only when user interact will specific option.

kumarpalsinh25 · 2025-01-03T04:54:45Z

app/lib/common/widgets/share/action/share_space_object_action.dart

-  NewsReferencesType? getNewsRefTypeFromObjType(ObjectType objectType) {
-    return switch (objectType) {
-      ObjectType.pin => NewsReferencesType.pin,
-      ObjectType.calendarEvent => NewsReferencesType.calendarEvent,
-      ObjectType.taskList => NewsReferencesType.taskList,
-      _ => null,
-    };
-  }
-
-  Future<RefDetails?> getRefDetails({
-    required WidgetRef ref,
-    required SpaceObjectDetails objectDetails,
-  }) async {
-    final objectId = objectDetails.objectId;
-    switch (objectDetails.objectType) {
-      case ObjectType.pin:
-        final sourcePin = await ref.watch(pinProvider(objectId).future);
-        return await sourcePin.refDetails();
-      case ObjectType.calendarEvent:
-        final sourceEvent =
-            await ref.watch(calendarEventProvider(objectId).future);
-        return await sourceEvent.refDetails();
-      case ObjectType.taskList:
-        final sourceTaskList =
-            await ref.watch(taskListProvider(objectId).future);
-        return await sourceTaskList.refDetails();
-      default:
-        return null;
-    }
-  }


Say Good bye to unwanted code as refDetails is now directly available from class param.

kumarpalsinh25 · 2025-01-03T04:55:32Z

app/lib/common/widgets/share/widgets/external_share_options.dart

-  final GestureTapCallback? onTapCopy;
-  final GestureTapCallback? onTapQr;
-  final GestureTapCallback? onTapSignal;
-  final GestureTapCallback? onTapWhatsApp;
-  final GestureTapCallback? onTapTelegram;
-  final GestureTapCallback? onTapMore;


Get rid of this callbacks as all of the options will be used when shareContent is available.

kumarpalsinh25 · 2025-01-03T04:56:42Z

app/lib/features/events/pages/event_details_page.dart

+      final refDetails = await event.refDetails();
+      final internalLink = refDetails.generateInternalLink(true);
      if (context.mounted) {
        openShareSpaceObjectDialog(
          context: context,
-          spaceObjectDetails: (
-            spaceId: event.roomIdStr(),
-            objectType: ObjectType.calendarEvent,
-            objectId: widget.calendarId,
-          ),
-          fileDetails: (
-            file: File(icalPath),
-            mimeType: 'text/calendar',
-          ),
+          refDetails: refDetails,
+          internalLink: internalLink,
+          shareContentBuilder: () => refDetails.generateExternalLink(),
+          fileDetailContentBuilder: () async {
+            final filename =
+                event.title().replaceAll(RegExp(r'[^A-Za-z0-9_-]'), '_');
+            final tempDir = await getTemporaryDirectory();
+            final icalPath = join(tempDir.path, '$filename.ics');
+            event.icalForSharing(icalPath);
+            return (
+              file: File(icalPath),
+              mimeType: 'text/calendar',
+            );
+          },
        );


General code optimisation based on the above mentioned changes.

kumarpalsinh25 · 2025-01-03T04:57:57Z

app/lib/features/invite_members/pages/share_invite_code.dart

+    return ExternalShareOptions(
+      qrContent: qrContent,
+      shareContentBuilder: () async => shareContent,


Used ExternalShareOptions common widget here also for user invites. This make sharing option more generic and removal of code duplication.

kumarpalsinh25 · 2025-01-03T05:00:08Z

app/lib/features/tasks/pages/task_list_details_page.dart

+            await openShareSpaceObjectDialog(
+              context: context,
+              refDetails: refDetails,
+              internalLink: internalLink,
+              shareContentBuilder: () => refDetails.generateExternalLink(),


This is the only change, other changes showing in this file are only related Code Format.

gnunicorn

But shouldn't we also close the share-dialog when someone clicked any of the things?

app/lib/common/widgets/share/action/shareTo.dart

gnunicorn · 2025-01-03T11:13:30Z

app/lib/common/widgets/share/action/shareTo.dart

+  required BuildContext context,
+  required String text,
+}) async {
+  if (Platform.isAndroid) {


We usually do the path of only showing features if they are available - if this isn't possible on iOS rather than showing some error messages, the button should not show up.

app/lib/common/widgets/share/widgets/external_share_options.dart

kumarpalsinh25 · 2025-01-03T14:14:10Z

But shouldn't we also close the share-dialog when someone clicked any of the things?

Due to common usage of ExternalShareOptions widget in Share user invite code, I removed Navigator.pop(context); from Share Dialog as it was closing share invite screen also.

But ya after changes related to shareContentBuilder suggestion, now it is possible to managed navigation independently in Share Dialog.

Did required changes and pushed the code.

Improvement in refDetail and Object sharing

faf6206

kumarpalsinh25 and others added 16 commits January 1, 2025 13:14

Code improvement in external share widget

9f42b20

Wording improvements

798d9c7

Use ExternalShareWidget in ShareInvite screen

c87f26c

Wording correction

474288d

Implemented external sharing options

703c1d6

Added WhatsApp Business support on external sharing options

025d87f

Manage external share widget by shareContentBuilder function

35c291a

Refactor RefDetails

8f650aa

disable retries for integration tests

0284e0c

Ensure local docker has the right setup

0819de6

expose external link generation

1ce5acd

Generate Internal Link via RefDetails

07fbad9

Fix reference building, adds tests

5320992

Direct share to Signal App option handling

6c8a45d

Merge remote-tracking branch 'origin/kumar/ref-details-improvements' …

6583e58

…into kumar/ref-details-improvements

Manage iCal sharing with fileDetailContentBuilder option

28d5fbd

kumarpalsinh25 commented Jan 3, 2025

View reviewed changes

kumarpalsinh25 changed the title ~~Improvement in refDetail and Object sharing~~ Improvement in refDetail and Space Object sharing enhacements Jan 3, 2025

kumarpalsinh25 changed the title ~~Improvement in refDetail and Space Object sharing enhacements~~ Improvement in refDetail and Space Object sharing enhancements Jan 3, 2025

kumarpalsinh25 added 2 commits January 3, 2025 10:41

Add changelog data

b0ac1cc

Add changelog data

6e2d1fd

kumarpalsinh25 marked this pull request as ready for review January 3, 2025 05:12

kumarpalsinh25 requested review from gnunicorn and gtalha07 January 3, 2025 11:09

gnunicorn approved these changes Jan 3, 2025

View reviewed changes

kumarpalsinh25 added 2 commits January 3, 2025 19:37

PR Feedback Points

c05328c

Transfer Share Folder from Common to Feature Folder

fc355da

kumarpalsinh25 enabled auto-merge January 3, 2025 14:14

kumarpalsinh25 merged commit e11211d into main Jan 3, 2025
21 of 22 checks passed

kumarpalsinh25 deleted the kumar/ref-details-improvements branch January 3, 2025 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement in refDetail and Space Object sharing enhancements #2472

Improvement in refDetail and Space Object sharing enhancements #2472

kumarpalsinh25 commented Dec 31, 2024 •

edited

Loading

codecov bot commented Dec 31, 2024 •

edited

Loading

kumarpalsinh25 left a comment

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

gnunicorn Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

kumarpalsinh25 Jan 3, 2025

gnunicorn left a comment

gnunicorn Jan 3, 2025

kumarpalsinh25 commented Jan 3, 2025

		Future<String> Function()? shareContentBuilder,
		Future<FileDetails> Function()? fileDetailContentBuilder,

Improvement in refDetail and Space Object sharing enhancements #2472

Improvement in refDetail and Space Object sharing enhancements #2472

Conversation

kumarpalsinh25 commented Dec 31, 2024 • edited Loading

codecov bot commented Dec 31, 2024 • edited Loading

Codecov Report

kumarpalsinh25 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gnunicorn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarpalsinh25 commented Jan 3, 2025

kumarpalsinh25 commented Dec 31, 2024 •

edited

Loading

codecov bot commented Dec 31, 2024 •

edited

Loading