Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to a specific boost #2490

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Linking to a specific boost #2490

merged 9 commits into from
Jan 10, 2025

Conversation

gnunicorn
Copy link
Contributor

This PR adds support for sharing and opening of specific boosts within the updates-section.

Demo:

screen-20250109-162308.mp4

Notice, how the share QR-code brings us right to the specific boost.

For the reviewer:

  • This expands the rust side by providing the necessary boost-type of ref-details
  • there is no UI yet for these in attachments or other places though
  • To link to a specific boost, we just look for it in the list and set the index accordingly, but we aren't yet directly addressing events via individual rust-apis
  • there are tests for the UI loading properly, including a new loading animation for cases where the app hasn't yet fetched the item...

@gnunicorn gnunicorn mentioned this pull request Jan 9, 2025
17 tasks
gnunicorn added a commit that referenced this pull request Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 29.12%. Comparing base (7743002) to head (1b8de53).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
native/acter/src/api/deep_linking.rs 0.00% 19 Missing ⚠️
native/core/src/events/common/object_reference.rs 0.00% 6 Missing ⚠️
native/acter/src/api/news.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2490      +/-   ##
==========================================
+ Coverage   28.24%   29.12%   +0.88%     
==========================================
  Files         680      680              
  Lines       45715    45487     -228     
==========================================
+ Hits        12910    13250     +340     
+ Misses      32805    32237     -568     
Flag Coverage Δ
integration-test 39.82% <0.00%> (+0.56%) ⬆️
unittest 20.19% <0.00%> (+1.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall flutter side code looks fine but have few queries which need to answer before merge.

  1. Boost external sharing supported or Not? If yes then may I have reference video showing deep link of the same?
  2. Does this PR also solve this issue Upon click of Notification of a boost doesn't go to the boost #2448 ?

@@ -0,0 +1 @@
- You can now share boosts via the QR-code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only via QR Code?
External sharing doesn't yet supported? I have seen external sharing options in video and haven't see any QR Specific restriction in this PR code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is meant to be user-facing thus I am focusing on the thing that already works nicely. The external sharing - as you point out correctly - still has some bugs so I am not advertising it here yet, despite it already being technically possible...

Comment on lines +69 to +71
if (itemIdx == null) {
// not found, still loading
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happen if boost is deleted by user/You try to scan QR of different space which he/she haven't joined yet? This will remain in still loading forever?

This can happen specially in ExternalLink sharing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this code - as well as any other where we have that case - this is endlessly loading, yes.

The plan is to have that case figured and caught in the url-parser and show something else in these cases: a message with the room they need to join first.

If it was deleted I am not sure what we want to do instead, but I'd just put that onto the lower burner for now, not a major use case.

@gnunicorn gnunicorn linked an issue Jan 10, 2025 that may be closed by this pull request
@gnunicorn
Copy link
Contributor Author

Boost external sharing supported or Not? If yes then may I have reference video showing deep link of the same?

Not that easy. As you point out, sharing is possible, yes, but not there are still enough cases where this is not working great to not advertise this.

Does this PR also solve this issue
#2448 ?

In combination with notification of comments of #2468, yes.

@gnunicorn gnunicorn enabled auto-merge January 10, 2025 14:42
@gnunicorn gnunicorn merged commit 1246daa into main Jan 10, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

Upon click of Notification of a boost doesn't go to the boost
2 participants