-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linking to a specific boost #2490
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
==========================================
+ Coverage 28.24% 29.12% +0.88%
==========================================
Files 680 680
Lines 45715 45487 -228
==========================================
+ Hits 12910 13250 +340
+ Misses 32805 32237 -568
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall flutter side code looks fine but have few queries which need to answer before merge.
- Boost external sharing supported or Not? If yes then may I have reference video showing deep link of the same?
- Does this PR also solve this issue Upon click of Notification of a boost doesn't go to the boost #2448 ?
@@ -0,0 +1 @@ | |||
- You can now share boosts via the QR-code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only via QR Code?
External sharing doesn't yet supported? I have seen external sharing options in video and haven't see any QR Specific restriction in this PR code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog is meant to be user-facing thus I am focusing on the thing that already works nicely. The external sharing - as you point out correctly - still has some bugs so I am not advertising it here yet, despite it already being technically possible...
if (itemIdx == null) { | ||
// not found, still loading | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happen if boost is deleted by user/You try to scan QR of different space which he/she haven't joined yet? This will remain in still loading forever?
This can happen specially in ExternalLink sharing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this code - as well as any other where we have that case - this is endlessly loading, yes.
The plan is to have that case figured and caught in the url-parser and show something else in these cases: a message with the room they need to join first.
If it was deleted I am not sure what we want to do instead, but I'd just put that onto the lower burner for now, not a major use case.
Not that easy. As you point out, sharing is possible, yes, but not there are still enough cases where this is not working great to not advertise this.
In combination with notification of comments of #2468, yes. |
This PR adds support for sharing and opening of specific boosts within the updates-section.
Demo:
screen-20250109-162308.mp4
Notice, how the share QR-code brings us right to the specific boost.
For the reviewer: