Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing notification support for iOS build #2496

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gnunicorn
Copy link
Contributor

Fixing what I broke with #2468

@gnunicorn gnunicorn added t-ios iOS Platform specific issues and tasks ci-build-ios build-demo Include demo builds in this PR minor This is a changeset with little need for review. labels Jan 14, 2025
@gnunicorn gnunicorn enabled auto-merge January 14, 2025 16:48
Copy link
Contributor

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

  • 📰 Add a markdown file in .changes/ explaining what changed

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.32%. Comparing base (0064430) to head (848da93).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
- Coverage   29.48%   27.32%   -2.16%     
==========================================
  Files         680      680              
  Lines       45488    44523     -965     
==========================================
- Hits        13413    12168    -1245     
- Misses      32075    32355     +280     
Flag Coverage Δ
integration-test 39.82% <ø> (ø)
unittest 18.43% <ø> (-2.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-demo Include demo builds in this PR ci-build-ios minor This is a changeset with little need for review. t-ios iOS Platform specific issues and tasks
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant