Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent avatar #12

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Fix parent avatar #12

merged 5 commits into from
Mar 8, 2024

Conversation

gnunicorn
Copy link

@gnunicorn gnunicorn commented Mar 6, 2024

As reported in acterglobal/a3#1184 : When the main avatar is going to fallback, we didn't show the parent avatar properly.

  1. Added an Example showing the problem (notice the parent of the third from the left)
    acter-avatar-fallback-failure
  2. Simplify code to just reuse the inner avatar for the parent
  3. Show it works:
    working--mini
  4. Add changelog entry
  5. Fix tests
  6. Add refreshing of avatar data upon Widget changes (to react to provider updates of avatar data)

@gnunicorn gnunicorn added the bug Something isn't working label Mar 6, 2024
@gnunicorn gnunicorn requested a review from gtalha07 March 6, 2024 20:48
@gnunicorn
Copy link
Author

@gtalha07 if you have any idea how to nicely test for 6, that'd be great!

@gtalha07
Copy link

gtalha07 commented Mar 8, 2024

@gtalha07 if you have any idea how to nicely test for 6, that'd be great!

Don't have idea rn how to validate refresh changes with tests but would come up with something later. We can proceed to merge it! ;)

Copy link

@gtalha07 gtalha07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks good....Thanks!

@gtalha07 gtalha07 merged commit 29ecf75 into main Mar 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants