Add support for duration primitive type in code generation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
gnunicorn
requested changes
May 11, 2024
You mean these tests aren't necessary or enough for checking duration representation ? Should I remove this ? |
gnunicorn
approved these changes
May 13, 2024
gnunicorn
requested changes
May 13, 2024
gnunicorn
reviewed
May 15, 2024
gnunicorn
reviewed
May 20, 2024
| @@ -365,6 +365,7 @@ pub fn generate_type(ty: &Type) -> dart::Tokens { | |||
| | Type::Int64 | |||
| | Type::UInt16 | |||
| | Type::Int32 | |||
| | Type::Duration | |||
There was a problem hiding this comment.
I am not sure this is needed at all....
gnunicorn
reviewed
May 20, 2024
| @@ -22,7 +24,8 @@ fn render_literal(literal: &Literal) -> String { | |||
| | Type::UInt32 | |||
| | Type::UInt64 | |||
| | Type::Float32 | |||
| | Type::Float64 => num_str, | |||
| | Type::Float64 | |||
| | Type::Duration => num_str, | |||
There was a problem hiding this comment.
neither that this is actually needed.
chavic
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
render_literalfunction for Duration literals.impl_code_type_for_primitive!andimpl_renderable_for_primitive!instances forDurationCodeType.liftDurationandlowerDurationfunctions togenerate_wrapper_liftersandgenerate_wrapper_lowerersrespectively.generate_wrapper_liftersandgenerate_wrapper_lowerersto handle Duration type.