Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backporting futures #35

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Backporting futures #35

merged 8 commits into from
Jun 4, 2024

Conversation

gnunicorn
Copy link
Contributor

from @chavic 's working branch into latest main:

  • reactives the future tests
  • copies over the futures implementation code
  • for that already takes over the new uniffi_function generation code (but not yet the singleton)
  • expands it over object methods
  • fixes the hello-world test failure problem
  • cleans up old, not necessary code and prints

Best viewed one commit at a time as these explain in the name what is even happening.

@gnunicorn gnunicorn requested review from chavic and gtalha07 May 31, 2024 15:17
Copy link
Contributor

@gtalha07 gtalha07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Although you probably wanna look at some test fails (but irrelevant to this PR)

@gnunicorn gnunicorn merged commit c7dc633 into main Jun 4, 2024
6 checks passed
@gnunicorn gnunicorn deleted the ben-merging-futures branch June 4, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants