Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrantBirki - Driveby 🚗 #817

Merged
merged 26 commits into from
Nov 2, 2023
Merged

GrantBirki - Driveby 🚗 #817

merged 26 commits into from
Nov 2, 2023

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Oct 31, 2023 •
edited
Loading

GrantBirki - Driveby 🚗

This is a classic @GrantBirki drive-by pull request

This pull request does the following:

  • Touches up the main readme
  • Adds a bit more documentation
  • Updates Actions CI jobs and their permissions (a bit)
  • Updates the test suite to suppress :debug: messages from being displayed in the output
  • Adds coverage badges to the readme
  • Adds the branding: block to the action.yml file - helpful for those of us publishing to the GitHub Marketplace
  • Adds a new workflow for globally validating JSON / YAML files throughout the project
  • Adds helper script (script/release) that maintainers can use to publish new release tags for their Actions

@GrantBirki GrantBirki self-assigned this Oct 31, 2023
@GrantBirki GrantBirki marked this pull request as ready for review October 31, 2023 23:59
@GrantBirki GrantBirki requested a review from ncalteen as a code owner October 31, 2023 23:59
ncalteen
ncalteen requested changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@ncalteen ncalteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Some minor nits but overall very helpful :D

script/release Outdated Show resolved Hide resolved
.github/workflows/json-yaml-validate.yml Outdated Show resolved Hide resolved
.github/workflows/linter.yml Show resolved Hide resolved
__tests__/main.test.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/json-yaml-validate.yml Outdated Show resolved Hide resolved
.github/config/exclude.txt Outdated Show resolved Hide resolved
__tests__/main.test.ts Outdated Show resolved Hide resolved
script/release Outdated Show resolved Hide resolved
ncalteen
ncalteen approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@ncalteen ncalteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution :D

@ncalteen ncalteen merged commit 7c769a1 into main Nov 2, 2023
6 checks passed
@ncalteen ncalteen deleted the grantbirki-driveby branch November 2, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncalteen ncalteen ncalteen approved these changes

Assignees

@GrantBirki GrantBirki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrantBirki @ncalteen