refactor: Use detector element to check if surface is sensitive (detray plugin)

[paulgessinger]

--- END COMMIT MESSAGE ---

@asalzburger, @niermann999 should we use the existence of a detector element to check if a surface is sensitive?

Summary by CodeRabbit

• New Features

  • Enhanced handling of surface types and geometry conversion processes.
  • Improved error handling with more descriptive runtime messages for unsupported surface types.

• Bug Fixes

  • Refined logic for determining surface types, particularly for cylindrical surfaces.

[coderabbitai]

Walkthrough

Changes made to the DetrayGeometryConverter.cpp file focus on the DetrayGeometryConverter class. The convertSurface method's logic has shifted to check for non-null detector elements instead of geometry ID sensitivity. The convertPortal method has been refined for better handling of surface types, particularly cylindrical surfaces, and enhanced error messaging for unsupported types has been added. Overall, these modifications improve the classification of surface types and the geometry conversion process.

Changes

File	Change Summary
Plugins/Detray/src/DetrayGeometryConverter.cpp	Logic in convertSurface, convertPortal, convertMask, convertVolume, and convertDetector methods updated; error handling improved; surface type classification refined.

Poem

In the depths of code, a change so bright,
Surfaces now dance in the soft moonlight. 🌙
With logic refined, and errors less grim,
Geometry flows, a harmonious hymn.
Oh, celebrate the craft, let the changes sing,
In the world of Detra, let new joys spring! 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6c910a6 and dd1c3cb.

📒 Files selected for processing (1)

• Plugins/Detray/src/DetrayGeometryConverter.cpp (1 hunks)

🔇 Additional comments (1)

Plugins/Detray/src/DetrayGeometryConverter.cpp (1)

62-62: Changed logic for surface sensitivity detection, you have.

Appropriate, this change seems. Using associatedDetectorElement() != nullptr to determine if surface is sensitive, wise it is.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[andiwand]

@paulgessinger looks like this is failing a test

[paulgessinger]

@andiwand I need to update this in any case.