refactor!: Explicit BoundaryTolerance constructors #3974
Conversation
|
Warning Rate limit exceeded@paulgessinger has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 15 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughIn the realm of boundary tolerance, a significant restructuring has occurred within the Changes
Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
Component - Core
|
paulgessinger
force-pushed
the
refactor/boundary-tolerance-explicit
branch
from
2729d6e to
ed92262
Compare
github-actions
bot
removed
Component - Fatras
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Core/include/Acts/Surfaces/BoundaryTolerance.hpp (1)
Line range hint
56-109: Wise move to private parameter structs, it is! Hmmmm.Strong encapsulation and validation, these parameter structs provide. Clear separation between interface and implementation, there now is.
A suggestion for consistency, I have:
- AbsoluteEuclideanParams() = default; - explicit AbsoluteEuclideanParams(double tolerance_) - : tolerance(tolerance_) {} + AbsoluteEuclideanParams() = default; + explicit AbsoluteEuclideanParams(double tolerance_) + : tolerance(tolerance_) { + // No validation needed for Euclidean tolerance as it can be negative + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
Core/include/Acts/Surfaces/BoundaryTolerance.hpp(4 hunks)Core/src/Geometry/TrapezoidVolumeBounds.cpp(1 hunks)Core/src/Surfaces/BoundaryTolerance.cpp(9 hunks)Examples/Io/Root/src/RootAthenaDumpReader.cpp(1 hunks)Tests/Benchmarks/AnnulusBoundsBenchmark.cpp(1 hunks)Tests/UnitTests/Core/Surfaces/BoundaryToleranceTests.cpp(3 hunks)Tests/UnitTests/Core/Surfaces/TrapezoidBoundsTests.cpp(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- Core/src/Geometry/TrapezoidVolumeBounds.cpp
- Tests/UnitTests/Core/Surfaces/TrapezoidBoundsTests.cpp
- Examples/Io/Root/src/RootAthenaDumpReader.cpp
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: merge-sentinel
🔇 Additional comments (5)
Core/include/Acts/Surfaces/BoundaryTolerance.hpp (2)
119-143: Clear and explicit, these factory methods are! Hmmmm.A better way to create tolerance instances, this is. Self-documenting and intuitive, the interface has become.
168-177: Backward compatibility maintained while encapsulation improved, it has been.Changed return types to parameter structs, yet stable interface preserved. Strong in the Force, this refactoring is!
Core/src/Surfaces/BoundaryTolerance.cpp (1)
22-31: Consistent with new parameter types, these changes are.Simple and clear, the variant checks have become. Improved readability without sacrificing functionality, we have achieved.
Also applies to: 35-43
Tests/Benchmarks/AnnulusBoundsBenchmark.cpp (1)
59-62: More explicit and consistent, these initializations have become.From brace to parentheses, the change flows. Explicit floating-point literals, clarity they bring.
Tests/UnitTests/Core/Surfaces/BoundaryToleranceTests.cpp (1)
42-46: Through accessor methods, the tests now flow. Hmmmm.Properly validate the refactored implementation, these tests do. Strong test coverage, maintained it has been.
Also applies to: 59-62, 74-78, 94-101
The commits contain two options on how to do this:
2729d6e(#3974)569e122(#3974)--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.Summary by CodeRabbit
Refactor
BoundaryToleranceclass internal representationStyle
The changes primarily focus on improving the internal structure of the
BoundaryToleranceclass while maintaining its existing functionality.