fix: compilation without geant4

[goetzgaycken]

• Remove unused header which is not available without geant4
• fix cmake target name

Summary by CodeRabbit

• New Features

  • Created a new shared library ActsExamplesDetectorGeoModel

• Refactor

  • Updated library configuration and dependencies
  • Removed GDML parser header from detector implementation

• Chores

  • Modified build configuration for library linking and source management

[coderabbitai]

Walkthrough

Hmm, a transformation in the GeoModel detector library, this pull request reveals. A new shared library, ActsExamplesDetectorGeoModel, emerges from the CMake configuration. Conditional compilation logic for Geant4 integration added, it has. Source files rearranged and dependencies carefully woven, the changes demonstrate a strategic restructuring of the detector framework.

Changes

File	Change Summary
Examples/Detectors/GeoModelDetector/CMakeLists.txt	- Created ActsExamplesDetectorGeoModel shared library - Added conditional Geant4 library linking - Modified target sources and dependencies
Examples/Detectors/GeoModelDetector/src/GeoModelDetector.cpp	- Removed G4GDMLParser.hh header inclusion

Possibly related PRs

• chore: Sonar fixes after detector refactor #3968: Modifications to Geant4MaterialRecording class, potentially related to detector framework integration

Suggested labels

automerge

Poem

In CMake's mystical grove,
A library springs to life, so bold
Geant4's whispers, softly told
Detectors dance, their code unfolds
A new path of knowledge, now we hold! 🌟🤖

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff60049 and c77f64b.

📒 Files selected for processing (2)

• Examples/Detectors/GeoModelDetector/CMakeLists.txt (1 hunks)
• Examples/Detectors/GeoModelDetector/src/GeoModelDetector.cpp (0 hunks)

💤 Files with no reviewable changes (1)

• Examples/Detectors/GeoModelDetector/src/GeoModelDetector.cpp

⏰ Context from checks skipped due to timeout of 90000ms (13)

• GitHub Check: merge-sentinel
• GitHub Check: CI Bridge / linux_ubuntu_2204
• GitHub Check: CI Bridge / lcg_106a: [alma9, clang16]
• GitHub Check: CI Bridge / lcg_106a: [alma9, gcc14]
• GitHub Check: CI Bridge / lcg_106a: [alma9, gcc13]
• GitHub Check: CI Bridge / lcg_105: [alma9, gcc13]
• GitHub Check: CI Bridge / linux_ubuntu_2204
• GitHub Check: CI Bridge / lcg_105: [alma9, clang16]
• GitHub Check: CI Bridge / linux_ubuntu_2204_clang
• GitHub Check: CI Bridge / build_exatrkx
• GitHub Check: CI Bridge / build_linux_ubuntu
• GitHub Check: CI Bridge / build_exatrkx_cpu
• GitHub Check: CI Bridge / clang_tidy

🔇 Additional comments (2)

Examples/Detectors/GeoModelDetector/CMakeLists.txt (2)

Line range hint 1-42: Wise changes for Geant4-less compilation, these are.

Handle both paths gracefully, this CMake configuration does. When Geant4 present is not, a stub implementation provided it has. When present Geant4 is, proper libraries linked they are.

---

33-35: Hmm, confused by the target name change, I am.

From ActsExamplesDetectorDD4hep to ActsExamplesDetectorGeoModel, the target name changes. Yet, in a GeoModel detector directory, we are. Explain this naming history, you must. A remnant of old code, perhaps this is?

Run this command to investigate the history, we shall:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[goetzgaycken]

Works for me, but I am not really sure whether all changes are necessary.

[github-actions]

📊: Physics performance monitoring for c77f64b

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud