move implementation to header files #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
yagiz/move-url-pattern-to-header
branch
2 times, most recently
from
b963cf5 to
eaffbd4
Compare
anonrig
force-pushed
the
yagiz/move-url-pattern-to-header
branch
from
eaffbd4 to
774c820
Compare
lemire
reviewed
Jan 23, 2025
anonrig
force-pushed
the
yagiz/move-url-pattern-to-header
branch
4 times, most recently
from
570cc44 to
3461e0e
Compare
anonrig
force-pushed
the
yagiz/move-url-pattern-to-header
branch
from
3461e0e to
7a62fa9
Compare
|
@lemire any idea how to solve this windows build error? |
Hmmm... Currently away from Windows. Let me check. |
lemire
approved these changes
Jan 24, 2025
|
So before you can do Easy. Peachy. I don't know why Visual Studio has this requirement exactly, maybe to help get better errors? |
|
Thanks @lemire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all url_pattern functions that uses a template argument to header files.