This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
[#32] Fix for 'h' not defined. #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This did not build for me (got another jsx error). But if you just upgrade microbundle it builds. The built files works, the h is finally defined 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the issue where 'h' is not defined. After a brief rabbit hole dive I've ran into this thread
developit/microbundle#12 (comment)
And the next couple of comments were really helpful.
Turns out that default "pragma" is
hbut it's possible to change to anything else, in this caseReact.createElementThe way I verified it's working is by building it, moving it to examples folder and using it in the example app. Let me know if I missed something.
Solves #32 and #31
PS. @adambrgmn just for visibility.