Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deliver dist folder #215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: deliver dist folder #215

wants to merge 2 commits into from

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Sep 26, 2024

Use our infrastructure to deliver the distribution files.

https://dist-deliver--helix-rum-js--adobe.aem.page/dist/rum-standalone.js 200
Do not expose the source: https://dist-deliver--helix-rum-js--adobe.aem.page/src/index.js 404

Copy link

aem-code-sync bot commented Sep 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

This PR will trigger a minor release when merged.

Copy link

aem-code-sync bot commented Sep 26, 2024

Page Scores Audits Google
📱 /dist/rum-standalone.js Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/javascript). PSI
🖥️ /dist/rum-standalone.js Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/javascript). PSI
📱 /src/index.js PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /src/index.js PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kptdobe kptdobe requested a review from trieloff September 26, 2024 13:43
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a4332f9) to head (4da3e94).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          179       179           
=========================================
  Hits           179       179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trieloff
Copy link
Contributor

I think the right way to do this would be to use the exec plugin https://github.com/semantic-release/exec to update a couple of git branches: deliver-x deliver-x-y and deliver-x-y-z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants