Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distached mobile menu ui #404

Merged
merged 4 commits into from
Oct 26, 2023
Merged

fix: distached mobile menu ui #404

merged 4 commits into from
Oct 26, 2023

Conversation

snowiewdev
Copy link
Collaborator

Quick fix as saw this when reading documentation in mobile breakpoints:

Screen Shot 2023-10-25 at 12 03 28 PM

Test URLs

Before: https://main--helix-website--adobe.hlx.live/docs/bulk-metadata
After: https://fix-mobile-spacing--helix-website--adobe.hlx.live/docs/bulk-metadata

Screen Shot 2023-10-25 at 12 04 06 PM

@snowiewdev snowiewdev requested a review from kptdobe October 25, 2023 19:05
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 25, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 25, 2023

Page Scores Audits Google
/docs/bulk-metadata PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 25, 2023

Page Scores Audits Google
/docs/bulk-metadata PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@snowiewdev snowiewdev marked this pull request as draft October 25, 2023 19:11
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 25, 2023

Page Scores Audits Google
/docs/bulk-metadata PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@snowiewdev snowiewdev marked this pull request as ready for review October 25, 2023 19:20
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 26, 2023

Page Scores Audits Google
/docs/bulk-metadata PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@kptdobe kptdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @snowiewdev!

@kptdobe kptdobe merged commit feff08d into main Oct 26, 2023
3 checks passed
@kptdobe kptdobe deleted the fix/mobile-spacing branch October 26, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants