Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RUM): visit entry to use enterSource facet from distiller #691

Merged
merged 3 commits into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/oversight/single.html
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ <h2>TTFB</h2>
<link-facet facet="clicktarget">
<legend>Click Target (URL)</legend>
</link-facet>
<link-facet facet="entersource" thumbnail="false">
<link-facet facet="enter.source" thumbnail="false">
<legend>External Referrer</legend>
<dl>
<dt>(direct)</dt>
Expand Down
7 changes: 7 additions & 0 deletions tools/oversight/slicer.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// eslint-disable-next-line import/no-relative-packages
import {
DataChunks, utils, series, facets,
// eslint-disable-next-line import/no-unresolved
} from '@adobe/rum-distiller';
import DataLoader from './loader.js';
import { parseSearchParams, parseConversionSpec } from './utils.js';
Expand All @@ -18,6 +19,7 @@
lcpSource,
lcpTarget,
acquisitionSource,
enterSource,
} = facets;

const {
Expand Down Expand Up @@ -242,7 +244,7 @@
));

if (cp === 'loadresource') {
console.log('adding histogram facet');

Check warning on line 247 in tools/oversight/slicer.js

View workflow job for this annotation

GitHub Actions / build

Unexpected console statement
// loadresource.target are not discrete values, but the number
// of milliseconds it took to load the resource, so the best way
// to present this is to create a histogram
Expand All @@ -261,6 +263,11 @@
if (cp === 'acquisition') {
dataChunks.addFacet('acquisition.source', acquisitionSource);
}

// special handling for enter checkpoint
if (cp === 'enter') {
dataChunks.addFacet('enter.source', enterSource);
}
});

if (typeof herochart.updateDataFacets === 'function') {
Expand Down
1 change: 1 addition & 0 deletions tools/rum/slicer.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// eslint-disable-next-line import/no-relative-packages
import {
DataChunks, utils, series, facets,
// eslint-disable-next-line import/no-unresolved
} from '@adobe/rum-distiller';
import DataLoader from './loader.js';
import { parseSearchParams, parseConversionSpec } from './utils.js';
Expand Down
Loading