Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: major lint #739

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore: major lint #739

merged 1 commit into from
Jan 9, 2025

Conversation

fkakatie
Copy link
Member

@fkakatie fkakatie commented Jan 9, 2025

Description

major linting effort. aspirationally, commits and PRs will stop failing the pre-checks.

generally, errors were:

  • unexpected spacing (4 spaces instead of 2, 2 instead of 0, et cetera)
  • hex codes contained uppercase letters (this feels new to me)
  • single quotes should be replaced with double quotes (another one that seems new to me)
  • decimals were missing leading zero
  • files needed a line break after the last character

Links

Details

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Jan 9, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jan 9, 2025

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@fkakatie fkakatie merged commit 2905900 into main Jan 9, 2025
4 checks passed
@fkakatie fkakatie deleted the lint branch January 9, 2025 22:15
@kptdobe
Copy link
Contributor

kptdobe commented Jan 10, 2025

Why was this PR necessary ? npm run lint was not complaining... ran it multiple times recently... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants